Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 2534873002: Use the Ahem font to try and deflake DomTreeExtractorBrowserTest (Closed)

Created:
4 years ago by alex clarke (OOO till 29th)
Modified:
4 years ago
Reviewers:
Sami
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use the Ahem font to try and deflake DomTreeExtractorBrowserTest BUG=546953 Committed: https://crrev.com/e961c3ef970570158b3f5c2c2393d04b059355e8 Cr-Commit-Position: refs/heads/master@{#434725}

Patch Set 1 #

Patch Set 2 : Try and upload again #

Patch Set 3 : . #

Patch Set 4 : Add some css #

Patch Set 5 : Added a copyright message #

Patch Set 6 : Try and use ahem on every element #

Unified diffs Side-by-side diffs Delta from patch set Stats (+220 lines, -153 lines) Patch
M headless/public/util/dom_tree_extractor_browsertest.cc View 1 2 3 4 5 25 chunks +196 lines, -151 lines 0 comments Download
A headless/test/data/Ahem.ttf View Binary file 0 comments Download
A headless/test/data/dom_tree_test.css View 1 2 3 4 5 1 chunk +21 lines, -0 lines 0 comments Download
M headless/test/data/dom_tree_test.html View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 33 (26 generated)
alex clarke (OOO till 29th)
4 years ago (2016-11-28 11:36:39 UTC) #4
Sami
lgtm.
4 years ago (2016-11-28 18:44:26 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534873002/100001
4 years ago (2016-11-28 18:45:27 UTC) #25
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
4 years ago (2016-11-28 20:48:02 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534873002/100001
4 years ago (2016-11-28 20:54:00 UTC) #29
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-11-28 21:48:44 UTC) #31
commit-bot: I haz the power
4 years ago (2016-11-28 21:51:56 UTC) #33
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/e961c3ef970570158b3f5c2c2393d04b059355e8
Cr-Commit-Position: refs/heads/master@{#434725}

Powered by Google App Engine
This is Rietveld 408576698