Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2534863002: Introduce markAllTreeScopesDirty. (Closed)

Created:
4 years ago by rune
Modified:
4 years ago
Reviewers:
meade_UTC10
CC:
chromium-reviews, blink-reviews-style_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce markAllTreeScopesDirty. When we need to recollect active stylesheets for all scopes, have an explicit markAllTreeScopesDirty method instead of relying on FullStyleUpdate which will go away for async active stylesheet updates. This CL does not contain functional changes. R=meade@chromium.org BUG=567021 Committed: https://crrev.com/c3481b639b36688d7f855ebd3de077dd9466a7f8 Cr-Commit-Position: refs/heads/master@{#434940}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M third_party/WebKit/Source/core/dom/StyleEngine.h View 3 chunks +8 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngine.cpp View 4 chunks +10 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/dom/StyleEngineTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
rune
ptal
4 years ago (2016-11-28 13:04:49 UTC) #5
meade_UTC10
lgtm
4 years ago (2016-11-29 03:23:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534863002/1
4 years ago (2016-11-29 09:37:09 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 09:41:48 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 09:43:44 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c3481b639b36688d7f855ebd3de077dd9466a7f8
Cr-Commit-Position: refs/heads/master@{#434940}

Powered by Google App Engine
This is Rietveld 408576698