Issue 2534833004: Request SearchResult(s) of multiple kinds at once.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2534833004: Request SearchResult(s) of multiple kinds at once. (Closed)

Created:
4 years ago by scheglov

Modified:
4 years ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Request SearchResult(s) of multiple kinds at once. This helps to reduce the number of times CompilationUnitElement is created for each file when we search for more than one kind of relation. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/95ae62b20bc9cad7172a85d3fb31159d80ab4dee

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -28 lines)			Patch
	M	pkg/analyzer/lib/src/dart/analysis/search.dart	View		7 chunks	+29 lines, -28 lines	0 comments	Download

Total messages: 4 (1 generated)

scheglov

4 years ago (2016-11-29 02:11:49 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
95ae62b20bc9cad7172a85d3fb31159d80ab4dee (presubmit successful).