Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 2534823003: Adds NativeWidgetAura::is_parallel_widget_in_window_manager (Closed)

Created:
4 years ago by sky
Modified:
4 years ago
CC:
chromium-reviews, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds NativeWidgetAura::is_parallel_widget_in_window_manager This is needed to ensure some operations don't attempt to modify state back on the underlying aura::Window when the window manager owns the window. BUG=664625 TEST=none R=ben@chromium.org Committed: https://crrev.com/c39c6e66c917ef43f4ce9e2a4a8ecd724de059a0 Cr-Commit-Position: refs/heads/master@{#434886}

Patch Set 1 #

Patch Set 2 : order #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M ui/views/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/DEPS View 1 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 2 chunks +6 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 7 chunks +13 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
sky
4 years ago (2016-11-28 23:57:48 UTC) #1
Ben Goodger (Google)
lgtm
4 years ago (2016-11-29 00:02:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534823003/20001
4 years ago (2016-11-29 04:07:02 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-29 04:15:48 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 04:22:22 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c39c6e66c917ef43f4ce9e2a4a8ecd724de059a0
Cr-Commit-Position: refs/heads/master@{#434886}

Powered by Google App Engine
This is Rietveld 408576698