Empty startup task queue when tasks run synchronously

Empty startup task queue when tasks run synchronously

Also empty it when a task fails, and ensure that callback is only
called once. Extend the tests to check all this.

TEST=content_unittests --gtest_filter='StartupTaskRunner*'
BUG=304108
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=228010

[sky, 2013-10-04 17:28:53]

Sorry, I'm not familiar with this code. Maybe John is?
+jam

[jam, 2013-10-07 16:17:03]

lgtm

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
File content/browser/startup_task_runner.cc (right):

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
content/browser/startup_task_runner.cc:31: startup_complete_callback_ =
base::Callback<void(int)>();
nit: startup_complete_callback_.Reset();

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
content/browser/startup_task_runner.cc:52: startup_complete_callback_ =
base::Callback<void(int)>();
ditto

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
content/browser/startup_task_runner.cc:73: startup_complete_callback_ =
base::Callback<void(int)>();
ditto

[aberent, 2013-10-10 13:56:36]

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
File content/browser/startup_task_runner.cc (right):

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
content/browser/startup_task_runner.cc:31: startup_complete_callback_ =
base::Callback<void(int)>();
On 2013/10/07 16:17:03, jam wrote:
> nit: startup_complete_callback_.Reset();

Done.

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
content/browser/startup_task_runner.cc:52: startup_complete_callback_ =
base::Callback<void(int)>();
On 2013/10/07 16:17:03, jam wrote:
> ditto

Done.

https://codereview.chromium.org/25348004/diff/1/content/browser/startup_task_...
content/browser/startup_task_runner.cc:73: startup_complete_callback_ =
base::Callback<void(int)>();
On 2013/10/07 16:17:03, jam wrote:
> ditto

Done.

[commit-bot: I haz the power, 2013-10-10 13:57:02]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2013-10-10 14:05:29]

No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[commit-bot: I haz the power, 2013-10-10 18:06:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/aberent@chromium.org/25348004/11001

[commit-bot: I haz the power, 2013-10-10 21:39:18]

Change committed as 228010