Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(102)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: test/mjsunit/regress/regress-crbug-669411.js
Issue
2534613002
:
[ic] Use validity cells to protect keyed element stores against object's prototype chain modificati… (Closed)
Patch Set: The fix
Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
include/v8.h
src/ast/ast-types.cc
src/builtins/builtins-array.cc
src/code-stub-assembler.h
src/compiler/types.cc
src/elements.cc
src/factory.h
src/factory.cc
src/ic/accessor-assembler.cc
src/ic/accessor-assembler-impl.h
src/ic/ic.h
src/ic/ic.cc
src/ic/ic-compiler.h
src/ic/ic-compiler.cc
src/ic/ic-inl.h
src/lookup.cc
src/objects.h
src/objects.cc
src/objects-debug.cc
src/objects-inl.h
src/objects-printer.cc
src/type-feedback-vector.h
src/type-feedback-vector.cc
src/value-serializer.cc
test/mjsunit/regress/regress-crbug-662907.js
test/mjsunit/regress/regress-crbug-669411.js
View unified diff
|
Download patch
« src/ic/accessor-assembler.cc
('K') |
« test/mjsunit/regress/regress-crbug-662907.js
('k') |
no next file »
|
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
// Copyright 2016 the V8 project authors. All rights reserved.
2
// Use of this source code is governed by a BSD-style license that can be
3
// found in the LICENSE file.
4
5
function f(o) {
6
o[5000000] = 0;
7
}
8
var o = Object.create(null);
9
f(o);
10
f(o);
11
f(o);
OLD
NEW
« src/ic/accessor-assembler.cc
('K') |
« test/mjsunit/regress/regress-crbug-662907.js
('k') |
no next file »
|
no next file with comments »
Issue 2534613002: [ic] Use validity cells to protect keyed element stores against object's prototype chain modificati… (Closed)
Created 4 years ago by Igor Sheludko
Modified 4 years ago
Reviewers: Jakob Kummerow, mvstanton
Base URL:
Comments: 7
This is Rietveld
408576698