Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2534533002: gfx: Fix [de]serializing non-shm GpuMemoryBufferHandle. (Closed)

Created:
4 years ago by sadrul
Modified:
4 years ago
Reviewers:
Tom Sepez
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gfx: Fix [de]serializing non-shm GpuMemoryBufferHandle. GpuMemoryBufferHandle::shared_memory_handle is only valid if type is SHARED_MEMORY_BUFFER. So try to serialize only when it's valid. BUG=643746 Committed: https://crrev.com/b5bc501b9a49ddd997b8f7c95edf336d51d35e32 Cr-Commit-Position: refs/heads/master@{#434740}

Patch Set 1 #

Patch Set 2 : test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -34 lines) Patch
M ui/gfx/mojo/buffer_types_traits.cc View 2 chunks +20 lines, -19 lines 0 comments Download
M ui/gfx/mojo/struct_traits_unittest.cc View 1 3 chunks +15 lines, -15 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
sadrul
4 years ago (2016-11-25 05:50:37 UTC) #4
Tom Sepez
lgtm
4 years ago (2016-11-28 17:23:10 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534533002/20001
4 years ago (2016-11-28 18:03:02 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-28 22:35:53 UTC) #13
commit-bot: I haz the power
4 years ago (2016-11-28 22:38:21 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b5bc501b9a49ddd997b8f7c95edf336d51d35e32
Cr-Commit-Position: refs/heads/master@{#434740}

Powered by Google App Engine
This is Rietveld 408576698