Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(304)

Issue 2534463003: [asm] Don't try to always-opt code which has AsmWasm data. (Closed)

Created:
4 years ago by rmcilroy
Modified:
4 years ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, bradnelson
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[asm] Don't try to always-opt code which has AsmWasm data. If code has AsmWasm data we shouldn't try to optimize the JS as well, since it will instead be optimized using the WASM data. BUG= Committed: https://crrev.com/f666bff8d6c44dbb063560610341233062731f07 Cr-Commit-Position: refs/heads/master@{#41293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/compiler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
rmcilroy
Benedkit, it turns out that this change is also necessary to unblock your CL at ...
4 years ago (2016-11-25 15:46:44 UTC) #4
Benedikt Meurer
Nice catch. LGTM.
4 years ago (2016-11-25 18:24:27 UTC) #7
rmcilroy
+bradnelson@ as FYI.
4 years ago (2016-11-25 20:54:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534463003/1
4 years ago (2016-11-25 20:55:07 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-26 04:46:56 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-26 04:47:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f666bff8d6c44dbb063560610341233062731f07
Cr-Commit-Position: refs/heads/master@{#41293}

Powered by Google App Engine
This is Rietveld 408576698