content/browser/notifications/notification_id_generator_unittest.cc - Issue 2534443002: Use notification display service to collect persistent notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/notifications/notification_id_generator_unittest.cc

Issue 2534443002: Use notification display service to collect persistent notifications. (Closed)

Patch Set: revert unit test Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/data/notifications/platform_notification_service.html ('K') | « content/browser/notifications/notification_id_generator.cc ('k') | content/browser/notifications/platform_notification_context_impl.cc » ('j') | content/browser/notifications/platform_notification_context_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/notifications/notification_id_generator_unittest.cc

diff --git a/content/browser/notifications/notification_id_generator_unittest.cc b/content/browser/notifications/notification_id_generator_unittest.cc

index 3b8b9bb4bfda472e4793390b6742301166a0d5d0..41a2a82213c09076f1b1a3d3c87c5253c58cf1e1 100644

--- a/content/browser/notifications/notification_id_generator_unittest.cc

+++ b/content/browser/notifications/notification_id_generator_unittest.cc

@@ -7,6 +7,7 @@

#include "base/macros.h"

#include "base/strings/string_number_conversions.h"

#include "content/browser/notifications/notification_id_generator.h"

+#include "content/public/browser/notification_id_verifier.h"

#include "content/public/test/test_browser_context.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "url/gurl.h"

@@ -279,14 +280,14 @@ TEST_F(NotificationIdGeneratorTest, DetectIdFormat) {

origin(), "" /* tag */, kNonPersistentNotificationId,

kRenderProcessId);

- EXPECT_TRUE(NotificationIdGenerator::IsPersistentNotification(persistent_id));

+ EXPECT_TRUE(NotificationIdVerifier::IsPersistentNotification(persistent_id));

EXPECT_FALSE(

- NotificationIdGenerator::IsNonPersistentNotification(persistent_id));

+ NotificationIdVerifier::IsNonPersistentNotification(persistent_id));

EXPECT_TRUE(

- NotificationIdGenerator::IsNonPersistentNotification(non_persistent_id));

+ NotificationIdVerifier::IsNonPersistentNotification(non_persistent_id));

EXPECT_FALSE(

- NotificationIdGenerator::IsPersistentNotification(non_persistent_id));

+ NotificationIdVerifier::IsPersistentNotification(non_persistent_id));

}

// -----------------------------------------------------------------------------