content/shell/browser/layout_test/layout_test_notification_manager.cc - Issue 2534443002: Use notification display service to collect persistent notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/layout_test/layout_test_notification_manager.cc

Issue 2534443002: Use notification display service to collect persistent notifications. (Closed)

Patch Set: fix layout tests Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/notifications/platform_notification_context_impl.cc ('K') | « content/shell/browser/layout_test/layout_test_notification_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/shell/browser/layout_test/layout_test_notification_manager.cc

diff --git a/content/shell/browser/layout_test/layout_test_notification_manager.cc b/content/shell/browser/layout_test/layout_test_notification_manager.cc

index 590bfda5635d1fe83f6a52351a353186b48576e2..b9a28756eab65dff97f3054261a408d6cf008d0e 100644

--- a/content/shell/browser/layout_test/layout_test_notification_manager.cc

+++ b/content/shell/browser/layout_test/layout_test_notification_manager.cc

@@ -83,10 +83,9 @@ void LayoutTestNotificationManager::ClosePersistentNotification(

persistent_notifications_.erase(notification_id);

}

-bool LayoutTestNotificationManager::GetDisplayedPersistentNotifications(

+bool LayoutTestNotificationManager::GetDisplayedNotifications(

BrowserContext* browser_context,

std::set<std::string>* displayed_notifications) {

- DCHECK_CURRENTLY_ON(BrowserThread::UI);

Miguel Garcia 2016/12/06 12:01:18 Note that I have removed this restriction since we

DCHECK(displayed_notifications);

// Notifications will never outlive the lifetime of running layout tests.