Use notification display service to collect persistent notifications.

content/browser/notifications/platform_notification_context_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/notifications/platform_notification_context_impl.h"
 
 #include "base/bind_helpers.h"
 #include "base/files/file_util.h"
 #include "base/memory/ptr_util.h"
 #include "base/metrics/histogram_macros.h"
@@ skipping 184 matching lines @@
                  std::vector<NotificationDatabaseData>()));
 }
 
 void PlatformNotificationContextImpl::
     DoReadAllNotificationDataForServiceWorkerRegistration(
         const GURL& origin,
         int64_t service_worker_registration_id,
         const ReadAllResultCallback& callback) {
   DCHECK(task_runner_->RunsTasksOnCurrentThread());
 
+  PlatformNotificationService* service =
+      GetContentClient()->browser()->GetPlatformNotificationService();
+
+  // Ask the underlying implementation what notifications are still being
+  // displayed.
+  std::set<std::string> displayed_notifications;
+  bool notification_synchronization_supported =
+      service &&

[Peter Beverloo, 2016/12/02 13:43:34]

Why would |service| be NULL?

[Miguel Garcia, 2016/12/06 12:01:18]

It's null in some context_unittests like
PlatformNotificationContextTest.ReadAllServiceWorkerDataEmpty

+      service->GetDisplayedPersistentNotifications(browser_context_,
+                                                   &displayed_notifications);
+
   std::vector<NotificationDatabaseData> notification_datas;
 
   NotificationDatabase::Status status =
       database_->ReadAllNotificationDataForServiceWorkerRegistration(
           origin, service_worker_registration_id, &notification_datas);
 
   UMA_HISTOGRAM_ENUMERATION("Notifications.Database.ReadForServiceWorkerResult",
                             status, NotificationDatabase::STATUS_COUNT);
 
   if (status == NotificationDatabase::STATUS_OK) {
+    if (notification_synchronization_supported) {
+      // Filter out notifications that are not actually on display anymore.
+      for (auto it = notification_datas.begin();
+           it != notification_datas.end();) {
+        if (displayed_notifications.count(it->notification_id))
+          ++it;
+        else
+          it = notification_datas.erase(it);
+      }

[Peter Beverloo, 2016/12/02 13:43:34]

We'll want to synchronize the database if there are any inconsistencies. It's
fine to do that as a follow-up, but please add a TODO.

[Miguel Garcia, 2016/12/06 12:01:18]

Done.

+    }
+
     BrowserThread::PostTask(
         BrowserThread::IO, FROM_HERE,
         base::Bind(callback, true /* success */, notification_datas));
     return;
   }
 
   // Blow away the database if reading data failed due to corruption.
   if (status == NotificationDatabase::STATUS_ERROR_CORRUPTED)
     DestroyDatabase();
 
@@ skipping 252 matching lines @@
 
   return path_.Append(kPlatformNotificationsDirectory);
 }
 
 void PlatformNotificationContextImpl::SetTaskRunnerForTesting(
     const scoped_refptr<base::SequencedTaskRunner>& task_runner) {
   task_runner_ = task_runner;
 }
 
 }  // namespace content