Use notification display service to collect persistent notifications.

chrome/browser/notifications/platform_notification_service_interactive_uitest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <memory>
 #include <string>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/path_service.h"
+#include "base/strings/string_piece.h"
+#include "base/strings/string_split.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/scoped_feature_list.h"
 #include "base/time/time.h"
 #include "chrome/browser/notifications/desktop_notification_profile_util.h"
 #include "chrome/browser/notifications/message_center_display_service.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/notifications/notification_test_util.h"
 #include "chrome/browser/notifications/platform_notification_service_impl.h"
 #include "chrome/browser/notifications/web_notification_delegate.h"
 #include "chrome/browser/permissions/permission_manager.h"
@@ skipping 548 matching lines @@
   const Notification& notification = ui_manager()->GetNotificationAt(0);
   ASSERT_EQ(1u, notification.buttons().size());
   EXPECT_EQ("actionTitle1", base::UTF16ToUTF8(notification.buttons()[0].title));
 
   notification.delegate()->ButtonClickWithReply(0, base::ASCIIToUTF16("hello"));
   ASSERT_TRUE(RunScript("GetMessageFromWorker()", &script_result));
   EXPECT_EQ("action_button_click actionId1 hello", script_result);
 }
 
 IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
+                       GetDisplayedNotifications) {
+  RequestAndAcceptPermission();
+
+  std::string script_result;
+  std::string script_message;
+  ASSERT_TRUE(RunScript("DisplayNonPersistentNotification('NonPersistent')",
+                        &script_result));
+  EXPECT_EQ("ok", script_result);
+  ASSERT_TRUE(RunScript("DisplayPersistentNotification('PersistentI')",
+                        &script_result));
+  EXPECT_EQ("ok", script_result);
+  ASSERT_TRUE(RunScript("DisplayPersistentNotification('PersistentII')",
+                        &script_result));
+  EXPECT_EQ("ok", script_result);
+
+  // Only the persistent ones should show.
+  ASSERT_TRUE(RunScript("GetDisplayedNotifications()", &script_result));
+  EXPECT_EQ("ok", script_result);
+
+  ASSERT_TRUE(RunScript("GetMessageFromWorker()", &script_message));
+  std::vector<std::string> notifications = base::SplitString(

[Peter Beverloo, 2016/12/02 13:43:34]

Consider using (from <algorithm>):

  ASSERT_EQ(1, std::count(script_message.begin(), script_message.end(), ','));

You don't use the values in |notifications| at any point, so we can remove the
allocations and additional work by simply counting the separators.

dito on line 619

[Miguel Garcia, 2016/12/06 12:01:18]

I rather count the elements, if I count the separator I need to add extra code
when there are none to see if there are 0 or 1 elements on the list which kinds
of defeats the purpose.

On 2016/12/02 13:43:34, Peter Beverloo wrote:

+      script_message, ",", base::KEEP_WHITESPACE, base::SPLIT_WANT_ALL);
+  ASSERT_EQ(2u, notifications.size());
+
+  // Now remove one notifications straight from the ui manager
+  // without going through the database.
+  // GetNotifications should report the correct number.
+  const Notification& notification = ui_manager()->GetNotificationAt(1);
+  base::StringPiece notification_id(notification.id());
+  ASSERT_TRUE(notification_id.starts_with("p:"));

[Peter Beverloo, 2016/12/02 13:43:34]

  ASSERT_TRUE(
      base::StartsWith(notification.id(), "p:", base::CompareCase::SENSITIVE));

(You might want to annotate in a comment what "p:" means.)

[Miguel Garcia, 2016/12/06 12:01:18]

Done.

+  ASSERT_TRUE(ui_manager()->ClearNotificationById(
+      notification.delegate_id(),
+      NotificationUIManager::GetProfileID(browser()->profile())));
+  ASSERT_TRUE(RunScript("GetDisplayedNotifications()", &script_result));
+  EXPECT_EQ("ok", script_result);
+
+  ASSERT_TRUE(RunScript("GetMessageFromWorker()", &script_message));
+  notifications = base::SplitString(script_message, ",", base::KEEP_WHITESPACE,
+                                    base::SPLIT_WANT_ALL);
+  ASSERT_EQ(1u, notifications.size());
+}
+
+IN_PROC_BROWSER_TEST_F(PlatformNotificationServiceBrowserTest,
                        TestShouldDisplayNormal) {
   ASSERT_NO_FATAL_FAILURE(GrantNotificationPermissionForTest());
   EnableFullscreenNotifications();
 
   std::string script_result;
   ASSERT_TRUE(RunScript(
       "DisplayPersistentNotification('display_normal')", &script_result));
   EXPECT_EQ("ok", script_result);
 
   ASSERT_EQ(1u, ui_manager()->GetNotificationCount());
@@ skipping 138 matching lines @@
       RunScript("DisplayPersistentAllOptionsNotification()", &script_result));
   EXPECT_EQ("ok", script_result);
 
   ASSERT_EQ(1u, ui_manager()->GetNotificationCount());
   const Notification& notification = ui_manager()->GetNotificationAt(0);
 
   // Since the kNotificationContentImage kill switch has disabled images, the
   // notification should be shown without an image.
   EXPECT_TRUE(notification.image().IsEmpty());
 }