chrome/browser/chromeos/login/screens/user_selection_screen.cc - Issue 2534433002: Mop up incorrect uses of IsEnterpriseManaged()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/screens/user_selection_screen.cc

Issue 2534433002: Mop up incorrect uses of IsEnterpriseManaged() (Closed)

Patch Set: Harmonize comments between InstallAttributes and BrowserPolicyConnectorChromeOS Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/screens/user_selection_screen.cc

diff --git a/chrome/browser/chromeos/login/screens/user_selection_screen.cc b/chrome/browser/chromeos/login/screens/user_selection_screen.cc

index fe4456577817112f144e2d351f375a7d8eeb8cbf..cbba36483b2c0280ab9e0914703557a589991598 100644

--- a/chrome/browser/chromeos/login/screens/user_selection_screen.cc

+++ b/chrome/browser/chromeos/login/screens/user_selection_screen.cc

@@ -74,7 +74,9 @@ void AddPublicSessionDetailsToUserDictionaryEntry(

policy::BrowserPolicyConnectorChromeOS* policy_connector =

g_browser_process->platform_part()->browser_policy_connector_chromeos();

- if (policy_connector->IsEnterpriseManaged()) {

+ // Active Directory would require a different treatment, but it doesn't

achuithb 2016/11/25 10:10:48 I think this comment may be more confusing than cl

Thiemo Nagel 2016/11/25 14:26:10 OK. I've removed that comment.

+ // support Public Session anyways.

+ if (policy_connector->IsCloudManaged()) {

user_dict->SetString(kKeyEnterpriseDomain,

policy_connector->GetEnterpriseDomain());

}