Mop up incorrect uses of IsEnterpriseManaged()

chrome/browser/chromeos/policy/browser_policy_connector_chromeos.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_POLICY_BROWSER_POLICY_CONNECTOR_CHROMEOS_H_
 #define CHROME_BROWSER_CHROMEOS_POLICY_BROWSER_POLICY_CONNECTOR_CHROMEOS_H_
 
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 53 matching lines @@
   // Shutdown() is called from BrowserProcessImpl::StartTearDown() but |this|
   // observes some objects that get destroyed earlier. PreShutdown() is called
   // from ChromeBrowserMainPartsChromeos::PostMainMessageLoopRun(), allowing the
   // connection to these dependencies to be severed earlier.
   void PreShutdown();
 
   void Shutdown() override;
 
   // Returns true if this device is managed by an enterprise (as opposed to
   // a local owner).
   bool IsEnterpriseManaged() const;

[Roman Sorokin (ftl), 2016/11/25 09:40:16]

What's up with that method? Should we delete it? Or rewrite comment?

[Thiemo Nagel, 2016/11/25 09:58:10]

We need to keep it, there's many legit uses of it.  Still I've synchronized the
comments with those in InstallAttributes for maximal clarity.

 
+  // Returns true if this device is enterprise-managed via Google's cloud (DM
+  // server).
+  bool IsCloudManaged() const;
+
+  // Returns true if this device is enterprise-managed via Active Directory.
+  bool IsActiveDirectoryManaged() const;
+
   // Returns the enterprise domain if device is managed.
   std::string GetEnterpriseDomain() const;
 
   // Returns the Kerberos realm (aka Windows Domain) if the device is managed by
   // Active Directory.
   std::string GetRealm() const;
 
   // Returns the device asset ID if it is set.
   std::string GetDeviceAssetID() const;
 
@@ skipping 116 matching lines @@
   std::unique_ptr<NetworkConfigurationUpdater> network_configuration_updater_;
 
   base::WeakPtrFactory<BrowserPolicyConnectorChromeOS> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserPolicyConnectorChromeOS);
 };
 
 }  // namespace policy
 
 #endif  // CHROME_BROWSER_CHROMEOS_POLICY_BROWSER_POLICY_CONNECTOR_CHROMEOS_H_