Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 2534423003: Convert edtitng/text-iterator/first-letter-word-boundary.html with assert_selection (Closed)

Created:
4 years ago by Xiaocheng
Modified:
4 years ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert edtitng/text-iterator/first-letter-word-boundary.html with assert_selection This patch converts the layout test with assert_selection to improve code health and also increase the usage of w3c testharness. Note: Chrome's current behavior is incorrect. It will be fixed by https://codereview.chromium.org/2541163003 BUG=n/a Committed: https://crrev.com/cc9f99ee58de94396041d8db5f22d67044a422b6 Cr-Commit-Position: refs/heads/master@{#436224}

Patch Set 1 #

Patch Set 2 : Add platform-dependent test results #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -55 lines) Patch
M third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary.html View 1 1 chunk +54 lines, -45 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/text-iterator/first-letter-word-boundary-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 18 (13 generated)
Xiaocheng
PTAL.
4 years ago (2016-12-05 02:29:17 UTC) #11
tkent
lgtm
4 years ago (2016-12-05 03:13:53 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534423003/20001
4 years ago (2016-12-05 03:15:20 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-05 03:19:37 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-05 03:22:01 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cc9f99ee58de94396041d8db5f22d67044a422b6
Cr-Commit-Position: refs/heads/master@{#436224}

Powered by Google App Engine
This is Rietveld 408576698