Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2534413005: Implement rewind on all platforms except for dbc. (Closed)

Created:
4 years ago by turnidge
Modified:
4 years ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement rewind on all platforms except for dbc. BUG= Committed: https://github.com/dart-lang/sdk/commit/e0d350aa27c1a4e09052cc1ca520e446c24d0049

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1001 lines, -182 lines) Patch
M runtime/observatory/lib/src/elements/debugger.dart View 11 chunks +95 lines, -29 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 4 chunks +7 lines, -3 lines 0 comments Download
M runtime/observatory/tests/service/pause_idle_isolate_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_and_exit_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M runtime/observatory/tests/service/pause_on_start_then_step_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
A runtime/observatory/tests/service/rewind_optimized_out_test.dart View 1 chunk +86 lines, -0 lines 0 comments Download
A runtime/observatory/tests/service/rewind_test.dart View 1 chunk +173 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/service.status View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/service_test_common.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M runtime/observatory/tests/service/set_vm_name_rpc_test.dart View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/step_over_await_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/tests/service/test_helper.dart View 14 chunks +31 lines, -56 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M runtime/vm/dart_entry.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/debugger.h View 6 chunks +33 lines, -7 lines 0 comments Download
M runtime/vm/debugger.cc View 13 chunks +305 lines, -18 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/exceptions.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/exceptions.cc View 4 chunks +16 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/json_stream.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/json_stream.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/raw_object.h View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/runtime_entry_list.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/service.cc View 2 chunks +50 lines, -24 lines 0 comments Download
M runtime/vm/simulator_dbc.cc View 1 chunk +13 lines, -2 lines 0 comments Download
M runtime/vm/stub_code.h View 3 chunks +8 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 3 chunks +28 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_arm64.cc View 3 chunks +28 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_dbc.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/stub_code_ia32.cc View 4 chunks +22 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_mips.cc View 3 chunks +28 lines, -5 lines 0 comments Download
M runtime/vm/stub_code_x64.cc View 3 chunks +27 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
turnidge
TBR=cutch
4 years ago (2016-12-02 01:19:01 UTC) #2
turnidge
4 years ago (2016-12-02 01:19:35 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e0d350aa27c1a4e09052cc1ca520e446c24d0049 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698