Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2534413002: MIPS: Improve Float(32|64)(Max|Min). (Closed)

Created:
4 years ago by Ilija.Pavlovic1
Modified:
4 years ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: Improve Float(32|64)(Max|Min). Port for 3396bb290701c600dd600081f04803b14f0f9084 TEST= BUG= Committed: https://crrev.com/7a6f294ffe8e9cc98e266238ec5cd0aa74524c4a Cr-Commit-Position: refs/heads/master@{#41508}

Patch Set 1 #

Patch Set 2 : MIPS: Improve Float(32|64)(Max|Min). #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1203 lines, -470 lines) Patch
M src/builtins/mips/builtins-mips.cc View 1 2 chunks +14 lines, -4 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 1 2 chunks +14 lines, -4 lines 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 2 chunks +60 lines, -32 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 2 chunks +60 lines, -32 lines 0 comments Download
M src/crankshaft/mips/lithium-codegen-mips.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/crankshaft/mips64/lithium-codegen-mips64.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 2 chunks +25 lines, -11 lines 0 comments Download
M src/mips/macro-assembler-mips.cc View 1 2 chunks +197 lines, -180 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 2 chunks +23 lines, -11 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 1 2 chunks +197 lines, -180 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 1 chunk +24 lines, -0 lines 0 comments Download
M test/cctest/test-macro-assembler-mips.cc View 1 3 chunks +291 lines, -4 lines 0 comments Download
M test/cctest/test-macro-assembler-mips64.cc View 1 3 chunks +291 lines, -4 lines 0 comments Download

Messages

Total messages: 27 (14 generated)
Ilija.Pavlovic1
PTAL
4 years ago (2016-11-30 12:22:37 UTC) #2
ivica.bogosavljevic
lgtm
4 years ago (2016-12-02 15:30:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534413002/1
4 years ago (2016-12-06 09:19:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30033)
4 years ago (2016-12-06 09:22:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534413002/20001
4 years ago (2016-12-06 09:37:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/30036)
4 years ago (2016-12-06 09:40:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534413002/20001
4 years ago (2016-12-06 09:50:26 UTC) #14
Ilija.Pavlovic1
Hello Benedikt, I would ask you for reviewing test/cctest/compiler/test-run-machops.cc Best regards Ilija
4 years ago (2016-12-06 09:58:19 UTC) #17
Benedikt Meurer
Sure, sorry for the delay. LGTM.
4 years ago (2016-12-06 10:10:14 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534413002/20001
4 years ago (2016-12-06 10:14:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534413002/20001
4 years ago (2016-12-06 10:15:27 UTC) #23
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-06 10:16:23 UTC) #25
commit-bot: I haz the power
4 years ago (2016-12-06 10:17:00 UTC) #27
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7a6f294ffe8e9cc98e266238ec5cd0aa74524c4a
Cr-Commit-Position: refs/heads/master@{#41508}

Powered by Google App Engine
This is Rietveld 408576698