Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2955)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2534403002: [ServiceWorker] Mojofy extendable message event. (Closed)
Patch Set: Fix win build Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index 780ce41fd6d53ac0f0a5d7386342bd67a00b3985..3307b090c858da843c9e9bd707b767e1b6c41c4f 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -227,6 +227,9 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
const std::string& tag,
blink::mojom::BackgroundSyncEventLastChance last_chance,
const DispatchSyncEventCallback& callback) override;
+ void DispatchExtendableMessageEvent(
shimazu 2016/12/02 04:00:33 Could you move this to l.222? I think it's better
leonhsl(Using Gerrit) 2016/12/02 08:36:44 Acknowledged.
leonhsl(Using Gerrit) 2016/12/02 15:43:27 Done.
+ mojom::ExtendableMessageEventPtr event,
+ const DispatchExtendableMessageEventCallback& callback) override;
void OnActivateEvent(int request_id);
void OnExtendableMessageEvent(
shimazu 2016/12/02 04:00:33 Could you remove this?
leonhsl(Using Gerrit) 2016/12/02 08:36:44 Acknowledged and thanks!
leonhsl(Using Gerrit) 2016/12/02 15:43:27 Done.

Powered by Google App Engine
This is Rietveld 408576698