Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Unified Diff: content/browser/service_worker/embedded_worker_test_helper.cc

Issue 2534403002: [ServiceWorker] Mojofy extendable message event. (Closed)
Patch Set: Fix win build Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/embedded_worker_test_helper.cc
diff --git a/content/browser/service_worker/embedded_worker_test_helper.cc b/content/browser/service_worker/embedded_worker_test_helper.cc
index 002432192da1b9d92fe9ed1162f098817caca747..3c0a0d1317b4865bd810368018191c0842947626 100644
--- a/content/browser/service_worker/embedded_worker_test_helper.cc
+++ b/content/browser/service_worker/embedded_worker_test_helper.cc
@@ -186,6 +186,14 @@ class EmbeddedWorkerTestHelper::MockServiceWorkerEventDispatcher
NOTIMPLEMENTED();
}
+ void DispatchExtendableMessageEvent(
+ mojom::ExtendableMessageEventPtr event,
+ const DispatchExtendableMessageEventCallback& callback) override {
+ if (!helper_)
+ return;
+ helper_->OnExtendableMessageEventStub(std::move(event), callback);
+ }
+
private:
base::WeakPtr<EmbeddedWorkerTestHelper> helper_;
const int thread_id_;
@@ -304,8 +312,6 @@ bool EmbeddedWorkerTestHelper::OnMessageToWorker(int thread_id,
current_embedded_worker_id_ = embedded_worker_id;
IPC_BEGIN_MESSAGE_MAP(EmbeddedWorkerTestHelper, message)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ActivateEvent, OnActivateEventStub)
- IPC_MESSAGE_HANDLER(ServiceWorkerMsg_ExtendableMessageEvent,
- OnExtendableMessageEventStub)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_InstallEvent, OnInstallEventStub)
IPC_MESSAGE_HANDLER(ServiceWorkerMsg_PushEvent, OnPushEventStub)
IPC_MESSAGE_UNHANDLED(handled = false)
@@ -329,11 +335,11 @@ void EmbeddedWorkerTestHelper::OnActivateEvent(int embedded_worker_id,
blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
}
-void EmbeddedWorkerTestHelper::OnExtendableMessageEvent(int embedded_worker_id,
- int request_id) {
- SimulateSend(new ServiceWorkerHostMsg_ExtendableMessageEventFinished(
- embedded_worker_id, request_id,
- blink::WebServiceWorkerEventResultCompleted, base::Time::Now()));
+void EmbeddedWorkerTestHelper::OnExtendableMessageEvent(
+ mojom::ExtendableMessageEventPtr event,
+ const mojom::ServiceWorkerEventDispatcher::
+ DispatchExtendableMessageEventCallback& callback) {
+ callback.Run(SERVICE_WORKER_OK, base::Time::Now());
}
void EmbeddedWorkerTestHelper::OnInstallEvent(int embedded_worker_id,
@@ -493,12 +499,12 @@ void EmbeddedWorkerTestHelper::OnActivateEventStub(int request_id) {
}
void EmbeddedWorkerTestHelper::OnExtendableMessageEventStub(
- int request_id,
- const ServiceWorkerMsg_ExtendableMessageEvent_Params& params) {
+ mojom::ExtendableMessageEventPtr event,
+ const mojom::ServiceWorkerEventDispatcher::
+ DispatchExtendableMessageEventCallback& callback) {
base::ThreadTaskRunnerHandle::Get()->PostTask(
- FROM_HERE,
- base::Bind(&EmbeddedWorkerTestHelper::OnExtendableMessageEvent,
- AsWeakPtr(), current_embedded_worker_id_, request_id));
+ FROM_HERE, base::Bind(&EmbeddedWorkerTestHelper::OnExtendableMessageEvent,
+ AsWeakPtr(), base::Passed(&event), callback));
}
void EmbeddedWorkerTestHelper::OnInstallEventStub(int request_id) {

Powered by Google App Engine
This is Rietveld 408576698