[ServiceWorker] Mojofy extendable message event.

content/browser/service_worker/service_worker_version.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/service_worker/service_worker_version.h"
 
 #include <stddef.h>
 
 #include <limits>
 #include <map>
@@ skipping 1055 matching lines @@
   // running status can be STARTING here.
   if (running_status() != EmbeddedWorkerStatus::STARTING &&
       running_status() != EmbeddedWorkerStatus::RUNNING) {
     return;
   }
 
   embedded_worker_->SendMessage(
       ServiceWorkerMsg_DidGetClients(request_id, *clients));
 }
 
+void ServiceWorkerVersion::OnSimpleEventFinished(
+    int request_id,
+    ServiceWorkerStatusCode status,
+    base::Time dispatch_event_time) {
+  // Copy error callback before calling FinishRequest.
+  PendingRequest* request = pending_requests_.Lookup(request_id);
+  DCHECK(request) << "Invalid request id";
+  StatusCallback callback = request->error_callback;
+
+  FinishRequest(request_id, status == SERVICE_WORKER_OK, dispatch_event_time);
+
+  callback.Run(status);
+}
+
 void ServiceWorkerVersion::OnSimpleEventResponse(

[shimazu, 2016/12/02 04:00:33]

How about deduping the codes by calling OnSimpleEventFinished in
OnSimpleEventResponse?

and I think the names should be the same because there is no difference between
the two. I prefer OnSimpleEventFinished to OnSimpleEventResponse because it's
clearer.

[leonhsl(Using Gerrit), 2016/12/02 08:36:44]

Acknowledged.

[leonhsl(Using Gerrit), 2016/12/02 15:43:27]

Put the duplicated codes into OnSimpleEventFinished and let
OnSimpleEventResponse call it. But for the naming change, if we renamed
OnSimpleEventResponse to OnSimpleEventFinished, at [1] base::Bind() can't deduce
which OnSimpleEventFinished should be bound.

[1]
https://cs.chromium.org/chromium/src/content/browser/service_worker/service_w...

[shimazu, 2016/12/05 03:40:21]

Thanks, I could understand why the names are different. How about adding a
comment about that (I put another comment to SWVersion) instead of renaming?

     int request_id,
     blink::WebServiceWorkerEventResult result,
     base::Time dispatch_event_time) {
   // Copy error callback before calling FinishRequest.
   PendingRequest* request = pending_requests_.Lookup(request_id);
   DCHECK(request) << "Invalid request id";
   StatusCallback callback = request->error_callback;
 
   FinishRequest(request_id,
                 result == blink::WebServiceWorkerEventResultCompleted,
@@ skipping 781 matching lines @@
 
 void ServiceWorkerVersion::CleanUpExternalRequest(
     const std::string& request_uuid,
     ServiceWorkerStatusCode status) {
   if (status == SERVICE_WORKER_OK)
     return;
   external_request_uuid_to_request_id_.erase(request_uuid);
 }
 
 }  // namespace content