Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Unified Diff: content/browser/frame_host/navigation_entry_impl.cc

Issue 2534393003: (Reland) Remove about:srcdoc url conversion. (Closed)
Patch Set: Rebase. Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/frame_host/navigation_entry_impl.cc
diff --git a/content/browser/frame_host/navigation_entry_impl.cc b/content/browser/frame_host/navigation_entry_impl.cc
index c02444372aa0c977ae288311098284cf6c870a69..e7736ca298bfffa2df1c14f3e9ed4ee828d72695 100644
--- a/content/browser/frame_host/navigation_entry_impl.cc
+++ b/content/browser/frame_host/navigation_entry_impl.cc
@@ -876,10 +876,10 @@ std::map<std::string, bool> NavigationEntryImpl::GetSubframeUniqueNames(
// that was the default URL. PageState doesn't matter there, because
// content injected into about:blank frames doesn't use it.
//
- // Be careful not to include iframe srcdoc URLs in this check, which do
- // need their PageState. The committed URL in that case gets rewritten to
- // about:blank, but we can detect it via the PageState's URL.
- //
+ // Be careful not to rely on FrameNavigationEntry's URLs in this check,
+ // because the committed URL in the browser could be rewritten to
+ // about:blank.
+ // See RenderProcessHostImpl::FilterURL to know which URLs are rewritten.
// See https://crbug.com/657896 for details.
bool is_about_blank = false;
ExplodedPageState exploded_page_state;

Powered by Google App Engine
This is Rietveld 408576698