Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2534383002: DevTools: [SuggestBox] migrate suggestbox icons onto UI.Icon (Closed)

Created:
4 years ago by lushnikov
Modified:
4 years ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: [SuggestBox] migrate suggestbox icons onto UI.Icon This patch allows suggestBox providers to specify suggestion icons. Suggestion Icons are displayed next to suggestion, and, importantly, they turn 'white' whenever the suggestion gets selected. In order to support this scenario, the 'force-white-icons' class is introduced. Whenever container is attributed with this css class, any descendant icons become white. BUG=669323 R=dgozman Committed: https://crrev.com/442e6b3e0058cdec555c8ea25fad6e06fe6735fd Cr-Commit-Position: refs/heads/master@{#435434}

Patch Set 1 #

Total comments: 6

Patch Set 2 : address comments + better centering #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -51 lines) Patch
M third_party/WebKit/Source/devtools/front_end/console/ConsolePrompt.js View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 2 chunks +11 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 4 chunks +17 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css View 1 1 chunk +19 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/suggestBox.css View 1 1 chunk +5 lines, -24 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
lushnikov
please, take a look
4 years ago (2016-11-30 08:09:07 UTC) #1
dgozman
lgtm https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right): https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js#newcode78 third_party/WebKit/Source/devtools/front_end/ui/Icon.js:78: this.classList.toggle('icon-mask', value && this._descriptor.isMask); !!this._descriptor.isMask https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css ...
4 years ago (2016-11-30 17:52:13 UTC) #6
lushnikov
Thanks! Addressed comments + did a centering with flexbox since it handles zooming better https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/devtools/front_end/ui/Icon.js ...
4 years ago (2016-11-30 20:29:18 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534383002/20001
4 years ago (2016-11-30 20:29:46 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-11-30 22:03:44 UTC) #12
commit-bot: I haz the power
4 years ago (2016-11-30 22:06:26 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/442e6b3e0058cdec555c8ea25fad6e06fe6735fd
Cr-Commit-Position: refs/heads/master@{#435434}

Powered by Google App Engine
This is Rietveld 408576698