DevTools: [SuggestBox] migrate suggestbox icons onto UI.Icon

DevTools: [SuggestBox] migrate suggestbox icons onto UI.Icon

This patch allows suggestBox providers to specify suggestion icons.

Suggestion Icons are displayed next to suggestion, and, importantly,
they turn 'white' whenever the suggestion gets selected.

In order to support this scenario, the 'force-white-icons' class is
introduced. Whenever container is attributed with this css class, any
descendant icons become white.

BUG=669323
R=dgozman

Committed: https://crrev.com/442e6b3e0058cdec555c8ea25fad6e06fe6735fd
Cr-Commit-Position: refs/heads/master@{#435434}

[lushnikov, 2016-11-30 08:09:07]

please, take a look

[lushnikov, 2016-11-30 08:09:14]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-30 08:09:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 09:17:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-30 09:17:36]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-11-30 17:52:13]

lgtm

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:78:
this.classList.toggle('icon-mask', value && this._descriptor.isMask);
!!this._descriptor.isMask

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:345:
.force-white-icons .spritesheet-smallicons {
Let's allow 'force-white-icons' on the icon itself as well.

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:353:
.force-white-icons .spritesheet-largeicons {
ditto

[lushnikov, 2016-11-30 20:29:18]

Thanks! Addressed comments + did a centering with flexbox since it handles
zooming better

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/Icon.js (right):

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/Icon.js:78:
this.classList.toggle('icon-mask', value && this._descriptor.isMask);
On 2016/11/30 17:52:13, dgozman wrote:
> !!this._descriptor.isMask

Done.

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css
(right):

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:345:
.force-white-icons .spritesheet-smallicons {
On 2016/11/30 17:52:13, dgozman wrote:
> Let's allow 'force-white-icons' on the icon itself as well.

Done.

https://codereview.chromium.org/2534383002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/inspectorCommon.css:353:
.force-white-icons .spritesheet-largeicons {
On 2016/11/30 17:52:13, dgozman wrote:
> ditto

Done.

[lushnikov, 2016-11-30 20:29:21]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-11-30 20:29:21]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2534383002/#ps20001
(title: "address comments + better centering")

[commit-bot: I haz the power, 2016-11-30 20:29:46]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-30 22:03:16]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480537761587940,
"parent_rev": "b33ee92f57beb22beedb128d5565256ab626d281", "commit_rev":
"62dd58c334bff5be7ece23574f16ed4d25242678"}

[commit-bot: I haz the power, 2016-11-30 22:03:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-30 22:06:25]

Description was changed from

==========
DevTools: [SuggestBox] migrate suggestbox icons onto UI.Icon

This patch allows suggestBox providers to specify suggestion icons.

Suggestion Icons are displayed next to suggestion, and, importantly,
they turn 'white' whenever the suggestion gets selected.

In order to support this scenario, the 'force-white-icons' class is
introduced. Whenever container is attributed with this css class, any
descendant icons become white.

BUG=669323
R=dgozman
==========

to

==========
DevTools: [SuggestBox] migrate suggestbox icons onto UI.Icon

This patch allows suggestBox providers to specify suggestion icons.

Suggestion Icons are displayed next to suggestion, and, importantly,
they turn 'white' whenever the suggestion gets selected.

In order to support this scenario, the 'force-white-icons' class is
introduced. Whenever container is attributed with this css class, any
descendant icons become white.

BUG=669323
R=dgozman

Committed: https://crrev.com/442e6b3e0058cdec555c8ea25fad6e06fe6735fd
Cr-Commit-Position: refs/heads/master@{#435434}
==========

[commit-bot: I haz the power, 2016-11-30 22:06:26]

Patchset 2 (id:??) landed as
https://crrev.com/442e6b3e0058cdec555c8ea25fad6e06fe6735fd
Cr-Commit-Position: refs/heads/master@{#435434}