components/new_or_sad_tab_strings.grdp - Issue 2534333002: Show 'Send Feedback' button on the sad tab page on multiple failures

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/new_or_sad_tab_strings.grdp

Issue 2534333002: Show 'Send Feedback' button on the sad tab page on multiple failures (Closed)

Patch Set: Fixed code based off of twellington's comments. Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/new_or_sad_tab_strings.grdp

diff --git a/components/new_or_sad_tab_strings.grdp b/components/new_or_sad_tab_strings.grdp

index b04b83d57f9a493c289935723f758d58f9c1e211..a88f66630c4d69bbf3420ecc86e3bced204a31da 100644

--- a/components/new_or_sad_tab_strings.grdp

+++ b/components/new_or_sad_tab_strings.grdp

@@ -31,6 +31,11 @@

Reload

</message>

+ <if expr="is_android">

+ <message name="IDS_SAD_TAB_SEND_FEEDBACK_LABEL" desc="Button label in the sad tab page for sending feedback. This label replaces the reload button after a crash happens twice in a row." formatter_data="android_java">

+ Send Feedback

+ </message>

+ </if>

<message name="IDS_NEW_TAB_TITLE"

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/tab/SadTabTest.java ('k') | tools/metrics/actions/actions.xml » ('j') | no next file with comments »