chrome/common/extensions/permissions/chrome_permission_message_provider.cc - Issue 253433002: Stop prompting for the file system write permission in packaged apps.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

Issue 253433002: Stop prompting for the file system write permission in packaged apps. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Indent Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/chrome_api_permissions.cc ('k') | chrome/common/extensions/permissions/permission_set_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/permissions/chrome_permission_message_provider.cc

diff --git a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

index c999ce066d39c25b8ad89f9589b86de2c7efd45b..26a5ae4693564a2b7aa4e46377cd583a2b66e826 100644

--- a/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

+++ b/chrome/common/extensions/permissions/chrome_permission_message_provider.cc

@@ -257,14 +257,10 @@ ChromePermissionMessageProvider::GetAPIPermissionMessages(

}

// A special hack: If kFileSystemWriteDirectory would be displayed, hide

- // kFileSystemDirectory and and kFileSystemWrite as the write directory

- // message implies the other two.

+ // kFileSystemDirectory as the write directory message implies it.

// TODO(sammc): Remove this. See http://crbug.com/284849.

SuppressMessage(messages,

PermissionMessage::kFileSystemWriteDirectory,

- PermissionMessage::kFileSystemWrite);

- SuppressMessage(messages,

- PermissionMessage::kFileSystemWriteDirectory,

PermissionMessage::kFileSystemDirectory);

// A special hack: The warning message for declarativeWebRequest

// permissions speaks about blocking parts of pages, which is a

@@ -335,8 +331,7 @@ bool ChromePermissionMessageProvider::IsAPIPrivilegeIncrease(

PermissionMsgSet delta_warnings =

base::STLSetDifference<PermissionMsgSet>(new_warnings, old_warnings);

- // A special hack: kFileSystemWriteDirectory implies kFileSystemDirectory and

- // kFileSystemWrite.

+ // A special hack: kFileSystemWriteDirectory implies kFileSystemDirectory.

// TODO(sammc): Remove this. See http://crbug.com/284849.

if (old_warnings.find(PermissionMessage(

PermissionMessage::kFileSystemWriteDirectory, base::string16())) !=

@@ -344,9 +339,6 @@ bool ChromePermissionMessageProvider::IsAPIPrivilegeIncrease(

delta_warnings.erase(

PermissionMessage(PermissionMessage::kFileSystemDirectory,

base::string16()));

- delta_warnings.erase(

- PermissionMessage(PermissionMessage::kFileSystemWrite,

- base::string16()));

}

// It is a privilege increase if there are additional warnings present.