Chromium Code Reviews| Index: chrome/common/extensions/permissions/permission_set_unittest.cc |
| diff --git a/chrome/common/extensions/permissions/permission_set_unittest.cc b/chrome/common/extensions/permissions/permission_set_unittest.cc |
| index 46682540f9f37f94980ff1121e281690a45d0ca7..751d25404a66e4ba0f3906e0d2860b963443493b 100644 |
| --- a/chrome/common/extensions/permissions/permission_set_unittest.cc |
| +++ b/chrome/common/extensions/permissions/permission_set_unittest.cc |
| @@ -755,6 +755,7 @@ TEST(PermissionsTest, PermissionMessages) { |
| skip.insert(APIPermission::kFileSystem); |
| skip.insert(APIPermission::kFileSystemProvider); |
| skip.insert(APIPermission::kFileSystemRetainEntries); |
| + skip.insert(APIPermission::kFileSystemWrite); |
| skip.insert(APIPermission::kSocket); |
| skip.insert(APIPermission::kUsbDevice); |
| @@ -785,7 +786,7 @@ TEST(PermissionsTest, FileSystemPermissionMessages) { |
| PermissionMessages messages = |
| PermissionMessageProvider::Get()->GetPermissionMessages( |
| permissions, Manifest::TYPE_PLATFORM_APP); |
| - ASSERT_EQ(2u, messages.size()); |
| + ASSERT_EQ(1u, messages.size()); |
| std::sort(messages.begin(), messages.end()); |
| std::set<PermissionMessage::ID> ids; |
| for (PermissionMessages::const_iterator it = messages.begin(); |
| @@ -793,7 +794,6 @@ TEST(PermissionsTest, FileSystemPermissionMessages) { |
| ids.insert(it->id()); |
| } |
| EXPECT_TRUE(ContainsKey(ids, PermissionMessage::kFileSystemDirectory)); |
| - EXPECT_TRUE(ContainsKey(ids, PermissionMessage::kFileSystemWrite)); |
| } |
| TEST(PermissionsTest, HiddenFileSystemPermissionMessages) { |
| @@ -892,8 +892,8 @@ TEST(PermissionsTest, MergedFileSystemPermissionComparison) { |
| EXPECT_TRUE(provider->IsPrivilegeIncrease(write_permissions, |
| write_directory_permissions, |
| Manifest::TYPE_PLATFORM_APP)); |
| - EXPECT_TRUE(provider->IsPrivilegeIncrease(directory_permissions, |
| - write_permissions, |
| + EXPECT_FALSE(provider->IsPrivilegeIncrease(directory_permissions, |
| + write_permissions, |
| Manifest::TYPE_PLATFORM_APP)); |
|
Sam McNally
2014/04/24 08:44:17
Nit: indentation.
|
| EXPECT_TRUE(provider->IsPrivilegeIncrease(directory_permissions, |
| write_directory_permissions, |