Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253433002: Stop prompting for the file system write permission in packaged apps. (Closed)

Created:
6 years, 8 months ago by benwells
Modified:
6 years, 7 months ago
Reviewers:
Sam McNally
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Stop prompting for the file system write permission in packaged apps. The user has to grant permission to specific files via a file picker, which is considered permission enough. BUG=363399 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267081

Patch Set 1 #

Total comments: 1

Patch Set 2 : Indent #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -23 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.cc View 1 chunk +1 line, -4 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 3 chunks +2 lines, -10 lines 0 comments Download
M chrome/common/extensions/permissions/permission_set_unittest.cc View 1 4 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/data/extensions/allow_silent_upgrade/platformapp2_new.json View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/common/permissions/permission_message.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
benwells
6 years, 8 months ago (2014-04-24 07:06:45 UTC) #1
Sam McNally
lgtm https://codereview.chromium.org/253433002/diff/1/chrome/common/extensions/permissions/permission_set_unittest.cc File chrome/common/extensions/permissions/permission_set_unittest.cc (right): https://codereview.chromium.org/253433002/diff/1/chrome/common/extensions/permissions/permission_set_unittest.cc#newcode897 chrome/common/extensions/permissions/permission_set_unittest.cc:897: Manifest::TYPE_PLATFORM_APP)); Nit: indentation.
6 years, 8 months ago (2014-04-24 08:44:17 UTC) #2
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 8 months ago (2014-04-24 10:09:43 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/253433002/20001
6 years, 8 months ago (2014-04-24 11:08:26 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-24 12:11:40 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-24 12:11:40 UTC) #6
benwells
The CQ bit was checked by benwells@chromium.org
6 years, 7 months ago (2014-04-30 03:49:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/253433002/20001
6 years, 7 months ago (2014-04-30 03:49:58 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 05:16:57 UTC) #9
Message was sent while issue was closed. 
Change committed as 267081

Powered by Google App Engine
This is Rietveld 408576698