Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issue 2534323002: Revert of "[wrapper-tracing] Enable flag per default" (Closed)

Created:
4 years ago by Ken Russell (switch to Gerrit)
Modified:
4 years ago
CC:
apavlov+blink_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of "[wrapper-tracing] Enable flag per default" (patchset #2 id:120001 of https://codereview.chromium.org/2540743003/ ) Reason for revert: Causing intermittent crashes, for example: https://build.chromium.org/p/chromium.gpu.fyi/builders/Mac%20Retina%20Release/builds/9294 https://chromium-swarm.appspot.com/task?id=32cb6753713de310&refresh=10&show_raw=1 WebglConformance_deqp_functional_gles3_fborender_shared_colorbuffer_02 (gpu_tests.webgl_conformance_integration_test.WebGLConformanceIntegrationTest) ... [27198:775:1129/161828:FATAL:ScriptWrappableVisitor.h(168)] Check failed: false. 0 Chromium Framework 0x00000001065df623 _ZN4base5debug10StackTraceC1Ev + 19 1 Chromium Framework 0x00000001066031d7 _ZN7logging10LogMessageD2Ev + 71 2 Chromium Framework 0x000000010a10902c _ZThn8_NK5blink22ScriptWrappableVisitor21dispatchTraceWrappersEPKv + 76 3 Chromium Framework 0x000000010a1080e5 _ZN5blink22ScriptWrappableVisitor14AdvanceTracingEdN2v818EmbedderHeapTracer21AdvanceTracingActionsE + 293 4 Chromium Framework 0x0000000104c898a3 _ZN2v88internal18IncrementalMarking4StepEmNS1_16CompletionActionENS1_21ForceCompletionActionENS0_10StepOriginE + 1475 5 Chromium Framework 0x0000000104c89e7b _ZN2v88internal18IncrementalMarking37AdvanceIncrementalMarkingOnAllocationEv + 363 6 Chromium Framework 0x0000000104cd5fed _ZN2v88internal8NewSpace16EnsureAllocationEiNS0_19AllocationAlignmentE + 429 7 Chromium Framework 0x0000000104c2e23f _ZN2v88internal4Heap11AllocateRawEiNS0_15AllocationSpaceENS0_19AllocationAlignmentE + 335 8 Chromium Framework 0x0000000104c69c6f _ZN2v88internal4Heap20AllocateFillerObjectEibNS0_15AllocationSpaceE + 31 9 Chromium Framework 0x0000000104c0cb7d _ZN2v88internal7Factory15NewFillerObjectEibNS0_15AllocationSpaceE + 45 10 Chromium Framework 0x0000000104f4b279 _ZN2v88internalL36__RT_impl_Runtime_AllocateInNewSpaceENS0_9ArgumentsEPNS0_7IsolateE + 89 11 Chromium Framework 0x0000000104f4af8e _ZN2v88internal26Runtime_AllocateInNewSpaceEiPPNS0_6ObjectEPNS0_7IsolateE + 238 12 ??? 0x000022c3837043a7 0x0 + 38223119139751 13 ??? 0x000022c3838ccbcb 0x0 + 38223121009611 14 ??? 0x000022c3842c5061 0x0 + 38223131463777 Original issue's description: > Reland of land "[wrapper-tracing] Enable flag per default" (patchset #2 id:150001 of https://codereview.chromium.org/2528393002/ ) > > Reason for revert: > Dev release happened. Enabling again. > > Original issue's description: > > Revert of Reland "[wrapper-tracing] Enable flag per default" (patchset #1 id:20001 of https://codereview.chromium.org/2503043002/ ) > > > > Reason for revert: > > Reverting because of upcomming Dev release. Will re-enable tomorrow after the release is done. > > > > Original issue's description: > > > Reland "[wrapper-tracing] Enable flag per default" > > > > > > BUG=chromium:468240 > > > > > > Committed: https://crrev.com/e23de6962be8b4967127ae95040f32bbb533b4d1 > > > Cr-Commit-Position: refs/heads/master@{#433823} > > > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org > > # Not skipping CQ checks because original CL landed more than 1 days ago. > > BUG=chromium:468240, chromium:668060, chromium:668059 > > > > Committed: https://crrev.com/2b5aa49038a8dd31697e3b9d636a26750a4ecdaa > > Cr-Commit-Position: refs/heads/master@{#434640} > > TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:468240, chromium:668060, chromium:668059 > > Committed: https://crrev.com/6dade445294d2a029c8c9407497ea7b883afe7ad > Cr-Commit-Position: refs/heads/master@{#435105} TBR=hlopko@chromium.org,haraken@chromium.org,hpayer@chromium.org,jochen@chromium.org,mlippautz@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:468240, chromium:668060, chromium:668059 Committed: https://crrev.com/d74646724afde2ddb5286f9863018730be150abf Cr-Commit-Position: refs/heads/master@{#435109}

Patch Set 1 #

Messages

Total messages: 9 (4 generated)
Ken Russell (switch to Gerrit)
Created Revert of "[wrapper-tracing] Enable flag per default"
4 years ago (2016-11-30 01:10:32 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534323002/1
4 years ago (2016-11-30 01:11:56 UTC) #3
haraken
LGTM to revert
4 years ago (2016-11-30 01:13:57 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-30 01:14:57 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-30 01:19:37 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d74646724afde2ddb5286f9863018730be150abf
Cr-Commit-Position: refs/heads/master@{#435109}

Powered by Google App Engine
This is Rietveld 408576698