Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2534313007:
Prevent default on tap when showing the credit card or address dialog. (Closed)
|
Created:
4 years ago by hcarmona Modified:
4 years ago Reviewers:
dpapad CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPrevent default on tap when showing the credit card or address dialog.
The on-tap event will focus whatever is underneath the tap event when it
finishes. Calling |preventDefault| on the event prevents this default
action. See https://github.com/Polymer/polymer/issues/4185 for details.
BUG=653415
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/ddbf37a7628ba691536fd980951f84d7a3a86864
Cr-Commit-Position: refs/heads/master@{#436341}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Address Nit #Messages
Total messages: 20 (14 generated)
Description was changed from ========== Prevent default on tap when showing the credit card or address dialog. The on-tap event will focus whatever is underneath the tap event when it finishes. Calling |preventDefault| on the event prevents this default action. See https://github.com/Polymer/polymer/issues/4185 for details. BUG=653415 ========== to ========== Prevent default on tap when showing the credit card or address dialog. The on-tap event will focus whatever is underneath the tap event when it finishes. Calling |preventDefault| on the event prevents this default action. See https://github.com/Polymer/polymer/issues/4185 for details. BUG=653415 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
hcarmona@chromium.org changed reviewers: + dpapad@chromium.org
PTAL
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM with nit. Also, don't we need to do this in other places? There are so many buttons that open dialogs in our UI. https://codereview.chromium.org/2534313007/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js (right): https://codereview.chromium.org/2534313007/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:84: * @private @param is missing now on all those handlers. Surprised that the compiler does not complain.
The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/12/03 01:02:02, dpapad wrote: > LGTM with nit. Also, don't we need to do this in other places? There are so many > buttons that open dialogs in our UI. Yes, this should be present in other places. I'll update the bug with a list of dialogs shown from a tap event. https://codereview.chromium.org/2534313007/diff/1/chrome/browser/resources/se... File chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js (right): https://codereview.chromium.org/2534313007/diff/1/chrome/browser/resources/se... chrome/browser/resources/settings/passwords_and_forms_page/autofill_section.js:84: * @private On 2016/12/03 01:02:02, dpapad wrote: > @param is missing now on all those handlers. Surprised that the compiler does > not complain. Done.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hcarmona@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from dpapad@chromium.org Link to the patchset: https://codereview.chromium.org/2534313007/#ps20001 (title: "Address Nit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1480959264587670,
"parent_rev": "b98b806356a51e6e9a5d3dbca1015af33a4ac894", "commit_rev":
"4c20b95ce0d6e3aeb531f12a3da619756fb64fa7"}
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Prevent default on tap when showing the credit card or address dialog. The on-tap event will focus whatever is underneath the tap event when it finishes. Calling |preventDefault| on the event prevents this default action. See https://github.com/Polymer/polymer/issues/4185 for details. BUG=653415 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== Prevent default on tap when showing the credit card or address dialog. The on-tap event will focus whatever is underneath the tap event when it finishes. Calling |preventDefault| on the event prevents this default action. See https://github.com/Polymer/polymer/issues/4185 for details. BUG=653415 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/ddbf37a7628ba691536fd980951f84d7a3a86864 Cr-Commit-Position: refs/heads/master@{#436341} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/ddbf37a7628ba691536fd980951f84d7a3a86864 Cr-Commit-Position: refs/heads/master@{#436341} |
