Add prototype D3D11VideoDecodeAccelerator.

Add prototype D3D11VideoDecodeAccelerator.

This uses the D3D11 video decoder API, which is lower level and may
improve power consumption and make it easier to debug issues without a
Media Foundation transform in the way.

This is missing a ton of features, all error checking, and decodes many
videos incorrectly, but could be useful for getting performance data.
It's disabled by default and behind the D3D11VideoDecoding feature flag.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/11c7629beff558f7f5822067dcfeb6d6a729d13b
Cr-Commit-Position: refs/heads/master@{#436011}

[jbauman, 2016-12-01 01:12:54]

Description was changed from

==========
Add prototype D3D11VideoDecodeAccelerator.

This uses the D3D11 video decoder API, which is lower level and may
improve power consumption and make it easier to debug issues without a
Media Foundation transform in the way.

This is missing a ton of features, all error checking, and decodes many
videos incorrectly, but could be useful for getting performance data.
It's disabled by default and behind the D3D11VideoDecoding feature flag.

BUG=
==========

to

==========
Add prototype D3D11VideoDecodeAccelerator.

This uses the D3D11 video decoder API, which is lower level and may
improve power consumption and make it easier to debug issues without a
Media Foundation transform in the way.

This is missing a ton of features, all error checking, and decodes many
videos incorrectly, but could be useful for getting performance data.
It's disabled by default and behind the D3D11VideoDecoding feature flag.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[jbauman, 2016-12-01 01:13:00]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 01:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 01:22:04]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[jbauman, 2016-12-01 01:27:26]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 01:27:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 02:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 02:12:59]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[jbauman, 2016-12-01 02:41:22]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 02:41:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-01 03:19:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-01 03:19:19]

Dry run: Try jobs failed on following builders:
  win_optional_gpu_tests_rel on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_optional_gpu_...)

[jbauman, 2016-12-01 22:08:17]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 22:08:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-12-01 22:40:50]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 22:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 00:17:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:17:26]

Dry run: This issue passed the CQ dry run.

[jbauman, 2016-12-02 00:31:01]

jbauman@chromium.org changed reviewers:
+ sandersd@chromium.org

[jbauman, 2016-12-02 00:31:01]

This code is really messy, but I think it's still good to have it in the tree at
least for benchmarking purposes.

[sandersd (OOO until July 31), 2016-12-02 00:52:57]

How do you want to schedule this review? There is enough code here that properly
reviewing it will take some time, which I assume is not what you want, but
waiting until it's ready to be turned on for a proper review isn't recommended
either.

https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
File media/gpu/d3d11_video_decode_accelerator_win.cc (right):

https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
media/gpu/d3d11_video_decode_accelerator_win.cc:5: #define INITGUID
Should this be undef'd later?

https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
File media/gpu/d3d11_video_decode_accelerator_win.h (right):

https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
media/gpu/d3d11_video_decode_accelerator_win.h:5: #ifndef
MEDIA_GPU_D3D11_VIDEO_DECODE_ACCELERATOR_H_
_WIN_H_?

https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
File media/gpu/d3d11_video_decoder.h (right):

https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
media/gpu/d3d11_video_decoder.h:1: // Copyright 2016 The Chromium Authors. All
rights reserved.
Recommend naming this something else; from the name I assume there is a
media::VideoDecoder impl.

[jbauman, 2016-12-02 01:57:24]

The CQ bit was checked by jbauman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-02 01:57:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbauman, 2016-12-02 02:02:05]

On 2016/12/02 00:52:57, sandersd wrote:
> How do you want to schedule this review? There is enough code here that
properly
> reviewing it will take some time, which I assume is not what you want, but
> waiting until it's ready to be turned on for a proper review isn't recommended
> either.
> 
Yeah, I think it would make sense for us to have a better idea of whether we
want to ship this before we spend time on doing a proper review. Once we get
more performance measurements and I can prioritize this work vs. overlays we can
decide that and start really reviewing it.

>
https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
> File media/gpu/d3d11_video_decode_accelerator_win.cc (right):
> 
>
https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
> media/gpu/d3d11_video_decode_accelerator_win.cc:5: #define INITGUID
> Should this be undef'd later?

Yeah, done.
> 
>
https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
> File media/gpu/d3d11_video_decode_accelerator_win.h (right):
> 
>
https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
> media/gpu/d3d11_video_decode_accelerator_win.h:5: #ifndef
> MEDIA_GPU_D3D11_VIDEO_DECODE_ACCELERATOR_H_
> _WIN_H_?
> 
Done.

>
https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
> File media/gpu/d3d11_video_decoder.h (right):
> 
>
https://codereview.chromium.org/2534313004/diff/80001/media/gpu/d3d11_video_d...
> media/gpu/d3d11_video_decoder.h:1: // Copyright 2016 The Chromium Authors. All
> rights reserved.
> Recommend naming this something else; from the name I assume there is a
> media::VideoDecoder impl.

Ok, renamed to d3d11_h264_accelerator.h

[commit-bot: I haz the power, 2016-12-02 04:06:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 04:06:34]

Dry run: This issue passed the CQ dry run.

[sandersd (OOO until July 31), 2016-12-02 19:26:14]

> Yeah, I think it would make sense for us to have a better idea of whether we
> want to ship this before we spend time on doing a proper review. Once we get
> more performance measurements and I can prioritize this work vs. overlays we
can
> decide that and start really reviewing it.

Sounds good. Just make sure you are comfortable doing significant refactoring
later, as may be required by a proper review.

lgtm.

[jbauman, 2016-12-02 19:56:51]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2016-12-02 19:57:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 21:06:15]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1480708611216550,
"parent_rev": "0896159fd14b1d4f23187a4462558532eb637ba7", "commit_rev":
"2f78e471bff589af86d46d287ca840151616e924"}

[commit-bot: I haz the power, 2016-12-02 21:06:48]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-12-02 21:08:43]

Description was changed from

==========
Add prototype D3D11VideoDecodeAccelerator.

This uses the D3D11 video decoder API, which is lower level and may
improve power consumption and make it easier to debug issues without a
Media Foundation transform in the way.

This is missing a ton of features, all error checking, and decodes many
videos incorrectly, but could be useful for getting performance data.
It's disabled by default and behind the D3D11VideoDecoding feature flag.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add prototype D3D11VideoDecodeAccelerator.

This uses the D3D11 video decoder API, which is lower level and may
improve power consumption and make it easier to debug issues without a
Media Foundation transform in the way.

This is missing a ton of features, all error checking, and decodes many
videos incorrectly, but could be useful for getting performance data.
It's disabled by default and behind the D3D11VideoDecoding feature flag.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/11c7629beff558f7f5822067dcfeb6d6a729d13b
Cr-Commit-Position: refs/heads/master@{#436011}
==========

[commit-bot: I haz the power, 2016-12-02 21:08:45]

Patchset 6 (id:??) landed as
https://crrev.com/11c7629beff558f7f5822067dcfeb6d6a729d13b
Cr-Commit-Position: refs/heads/master@{#436011}