Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 2534303002: Make QuicCryptoClientConfig only cache server configs for 1 week. (Closed)

Created:
4 years ago by Ryan Hamilton
Modified:
4 years ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make QuicCryptoClientConfig only cache server configs for 1 week. Merge internal change: 140540620 BUG=669671 Committed: https://crrev.com/f2585be417280721a8f00ec802ca50e01597295b Cr-Commit-Position: refs/heads/master@{#435185}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -10 lines) Patch
M net/quic/core/crypto/quic_crypto_client_config.cc View 1 2 3 chunks +13 lines, -10 lines 0 comments Download
M net/quic/core/crypto/quic_crypto_client_config_test.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M net/quic/core/quic_constants.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
Ryan Hamilton
4 years ago (2016-11-29 23:03:43 UTC) #2
Zhongyi Shi
lgtm
4 years ago (2016-11-29 23:24:38 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534303002/1
4 years ago (2016-11-29 23:25:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_cronet on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_cronet/builds/43918) ios-device on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years ago (2016-11-29 23:34:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534303002/20001
4 years ago (2016-11-29 23:44:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534303002/40001
4 years ago (2016-11-30 00:17:55 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 02:20:37 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534303002/40001
4 years ago (2016-11-30 03:39:24 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-11-30 09:00:02 UTC) #22
commit-bot: I haz the power
4 years ago (2016-11-30 09:02:11 UTC) #24
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/f2585be417280721a8f00ec802ca50e01597295b
Cr-Commit-Position: refs/heads/master@{#435185}

Powered by Google App Engine
This is Rietveld 408576698