Migrate tests for initializing formals

Migrate tests for initializing formals

BUG=#27894
R=eernst@google.com

Committed: https://github.com/dart-lang/sdk/commit/94e4a9867191e831453599e273e93bcecb2f96b7

[vsm, 2016-11-29 23:00:51]

Description was changed from

==========
Migrate tests for initializing formals

BUG=#27894
==========

to

==========
Migrate tests for initializing formals

BUG=#27894
==========

[vsm, 2016-11-29 23:00:52]

vsm@google.com changed reviewers:
+ eernst@google.com

[vsm, 2016-11-29 23:00:57]

https://codereview.chromium.org/2534293002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/language/initializing_formal_final_test.dart
(right):

https://codereview.chromium.org/2534293002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/language/initializing_formal_final_test.dart:13:
// accessed as an initializing formal.
Erik: This should be an error in strong mode, right?  Is there a tracking bug
for that?

[eernst, 2016-11-30 10:22:46]

LGTM, noting that it raises a couple of questions (which shouldn't delay the
landing of this CL, but may still be useful to think about):

1. Do we have a more durable solution to "one test, two outcomes" than status
file entries?

2. How do you usually handle tests that are intended to check that certain type
violations are detected?

https://codereview.chromium.org/2534293002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/language/initializing_formal_final_test.dart
(right):

https://codereview.chromium.org/2534293002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/language/initializing_formal_final_test.dart:13:
// accessed as an initializing formal.
On 2016/11/29 23:00:57, vsm wrote:
> Erik: This should be an error in strong mode, right?  Is there a tracking bug
> for that?

Right, `dartanalyzer --strong ..` considers assignment to final to be an error.

As far as I can see, we don't have a general solution: There is one test, and it
should be a `CompileTimeError` in some cases and successful in others (because
`dart2js` warnings are not compile-time errors according to `test.py`:
compilation succeeds with an invisible warning, and execution succeeds because
the `noSuchMethod` error caused by the missing setter gets caught and handled).

One thing we can do for now is to make sure we have entries in the status files.
I suppose this is what you already put into 'language_tests.js' (btw, I guess
you can't mark it as a compile-time error there? ..and that it is the correct
error which is emitted?).

I created https://github.com/dart-lang/sdk/issues/27934 to ensure that we check
for dart2js that there is a warning, and that it is the correct warning.

I'm not aware of an issue about this test having a CompileTimeError in strong
mode, but I wouldn't know what to ask for (except for status entries).

https://codereview.chromium.org/2534293002/diff/1/pkg/dev_compiler/test/codeg...
File pkg/dev_compiler/test/codegen/language/initializing_formal_type_test.dart
(right):

https://codereview.chromium.org/2534293002/diff/1/pkg/dev_compiler/test/codeg...
pkg/dev_compiler/test/codegen/language/initializing_formal_type_test.dart:16:
A(int this.x) : y = x {
I would expect the above initialization to be an error in strong mode as well:
It is an `int` value being stored in a `double` variable.

So it should get the same treatment as initializing_formal_final_test.dart (and
I created a similar issue https://github.com/dart-lang/sdk/issues/27936, to
check that we get the correct warning from dart2js).

I can see that there is an entry in 'not_yet_strong_tests.dart' below for this
test, but it is actually not a test which is intended to be updated such that it
has no type violations, it is a test that creates a typing situation which must
be detected and rejected (in strong mode, or warned about in standard mode). So
how do you usually handle that?

[vsm, 2016-12-07 18:58:12]

Description was changed from

==========
Migrate tests for initializing formals

BUG=#27894
==========

to

==========
Migrate tests for initializing formals

BUG=#27894
R=eernst@google.com

Committed:
https://github.com/dart-lang/sdk/commit/94e4a9867191e831453599e273e93bcecb2f96b7
==========

[vsm, 2016-12-07 18:58:14]

Committed patchset #1 (id:1) manually as
94e4a9867191e831453599e273e93bcecb2f96b7 (presubmit successful).