Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 2534263002: Make the dart:developer library available in DDC so debugger statement works (Closed)

Created:
4 years ago by Alan Knight
Modified:
4 years ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make the dart:developer library available in DDC so debugger statement works BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/667fc8dbe948b62ee2ca66e187fb84cf7e306b27

Patch Set 1 #

Patch Set 2 : Remove debugging statement #

Total comments: 1

Patch Set 3 : Deleted unneeded gyp file #

Patch Set 4 : Merged #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4068 lines, -57 lines) Patch
M pkg/dev_compiler/lib/js/amd/dart_sdk.js View 1 2 3 9 chunks +776 lines, -19 lines 0 comments Download
M pkg/dev_compiler/lib/js/common/dart_sdk.js View 1 2 3 9 chunks +776 lines, -19 lines 0 comments Download
M pkg/dev_compiler/lib/js/es6/dart_sdk.js View 1 2 3 4 chunks +756 lines, -0 lines 0 comments Download
M pkg/dev_compiler/lib/js/legacy/dart_sdk.js View 1 2 3 9 chunks +776 lines, -19 lines 0 comments Download
M pkg/dev_compiler/lib/sdk/ddc_sdk.sum View 1 2 3 Binary file 0 comments Download
M pkg/dev_compiler/tool/build_sdk.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/dev_compiler/tool/input_sdk/lib/_internal/libraries.dart View 1 chunk +5 lines, -0 lines 0 comments Download
A pkg/dev_compiler/tool/input_sdk/lib/developer/developer.dart View 1 chunk +60 lines, -0 lines 0 comments Download
A pkg/dev_compiler/tool/input_sdk/lib/developer/extension.dart View 1 chunk +177 lines, -0 lines 0 comments Download
A pkg/dev_compiler/tool/input_sdk/lib/developer/profiler.dart View 1 chunk +197 lines, -0 lines 0 comments Download
A pkg/dev_compiler/tool/input_sdk/lib/developer/service.dart View 1 chunk +89 lines, -0 lines 0 comments Download
A pkg/dev_compiler/tool/input_sdk/lib/developer/timeline.dart View 1 chunk +328 lines, -0 lines 0 comments Download
A pkg/dev_compiler/tool/input_sdk/patch/developer_patch.dart View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Alan Knight
4 years ago (2016-11-29 22:35:35 UTC) #2
vsm
lgtm https://codereview.chromium.org/2534263002/diff/20001/pkg/dev_compiler/tool/input_sdk/lib/developer/developer_sources.gypi File pkg/dev_compiler/tool/input_sdk/lib/developer/developer_sources.gypi (right): https://codereview.chromium.org/2534263002/diff/20001/pkg/dev_compiler/tool/input_sdk/lib/developer/developer_sources.gypi#newcode1 pkg/dev_compiler/tool/input_sdk/lib/developer/developer_sources.gypi:1: # Copyright (c) 2015, the Dart project authors. ...
4 years ago (2016-11-29 22:45:09 UTC) #3
Alan Knight
On 2016/11/29 22:45:09, vsm wrote: > lgtm > > https://codereview.chromium.org/2534263002/diff/20001/pkg/dev_compiler/tool/input_sdk/lib/developer/developer_sources.gypi > File pkg/dev_compiler/tool/input_sdk/lib/developer/developer_sources.gypi > (right): ...
4 years ago (2016-11-29 23:59:37 UTC) #4
Alan Knight
4 years ago (2016-11-30 00:13:54 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as
667fc8dbe948b62ee2ca66e187fb84cf7e306b27 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698