Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2534243003:
Remove TODO for smart page. (Closed)
|
Created:
4 years ago by Robert Ogden Modified:
4 years ago Reviewers:
sclittle CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove TODO for smart page.
Doesn't actually add any features, breaks things down the line.
BUG=669956
Committed: https://crrev.com/90653cee40f4651debda27fc33f34bac224fd473
Cr-Commit-Position: refs/heads/master@{#435502}
Patch Set 1 #Patch Set 2 : Remove testing code. Oops. #Patch Set 3 : Abandon changes, remove TODO #Patch Set 4 : Fix git troubles #Messages
Total messages: 19 (9 generated)
Description was changed from ========== Adds smart page to test framework. BUG= ========== to ========== Adds smart page to test framework. BUG=669956 ==========
robertogden@chromium.org changed reviewers: + sclittle@chromium.org
Test framework is already underway. Here's a cl to get you included as I spread out the reviews. Thanks
robertogden@chromium.org changed reviewers: - sclittle@chromium.org
Wait, hold off on this one. This might break something later down the road. Still testing...
On 2016/11/30 20:33:40, Robert Ogden wrote: > Wait, hold off on this one. This might break something later down the road. > Still testing... Gotcha, thanks for the heads up. Let me know when you want me to take a look.
Looks like a smart page will break listening for javascript events down the road, so I'm just going to drop this one. CL now just removes the TODO
robertogden@chromium.org changed reviewers: + sclittle@chromium.org
Looks like a smart page will break listening for javascript events down the road, so I'm just going to drop this one. CL now just removes the TODO
Description was changed from ========== Adds smart page to test framework. BUG=669956 ========== to ========== Remove TODO for smart page. Doesn't actually add any features, breaks things down the line. BUG=669956 ==========
Got it now. PTAL. Thanks.
lgtm
The CQ bit was checked by robertogden@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1480552516203570,
"parent_rev": "954ffe863159ef840dd3e260ff4c0ea2126088ff", "commit_rev":
"565d1130119832773d72fdb119ae3f9c4e7f089b"}
Message was sent while issue was closed.
Description was changed from ========== Remove TODO for smart page. Doesn't actually add any features, breaks things down the line. BUG=669956 ========== to ========== Remove TODO for smart page. Doesn't actually add any features, breaks things down the line. BUG=669956 ==========
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Remove TODO for smart page. Doesn't actually add any features, breaks things down the line. BUG=669956 ========== to ========== Remove TODO for smart page. Doesn't actually add any features, breaks things down the line. BUG=669956 Committed: https://crrev.com/90653cee40f4651debda27fc33f34bac224fd473 Cr-Commit-Position: refs/heads/master@{#435502} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/90653cee40f4651debda27fc33f34bac224fd473 Cr-Commit-Position: refs/heads/master@{#435502} |
