Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2534243002: [tools/perf] Enable loading metrics for common system health benchmarks (Closed)

Created:
4 years ago by nednguyen
Modified:
4 years ago
CC:
chromium-reviews, telemetry-reviews_chromium.org, charliea (OOO until 10-5)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[tools/perf] Enable loading metrics for common system health benchmarks BUG=chromium:669526 Committed: https://crrev.com/ba3f0989e24c659d2b204918b40c0ece13cc2335 Cr-Commit-Position: refs/heads/master@{#435527}

Patch Set 1 #

Patch Set 2 : Rename #

Patch Set 3 : Fix loading.cluster_telemetry #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -9 lines) Patch
M tools/perf/benchmarks/loading.py View 1 2 3 chunks +7 lines, -2 lines 0 comments Download
M tools/perf/benchmarks/page_cycler_v2.py View 1 3 chunks +6 lines, -7 lines 0 comments Download
M tools/perf/benchmarks/system_health.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (19 generated)
nednguyen
4 years ago (2016-11-29 21:46:03 UTC) #4
Kunihiko Sakamoto
lgtm
4 years ago (2016-11-30 00:44:04 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534243002/40001
4 years ago (2016-11-30 01:00:37 UTC) #16
kouhei (in TOK)
lgtm
4 years ago (2016-11-30 01:40:03 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: blimp_linux_dbg on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) cast_shell_linux on ...
4 years ago (2016-11-30 01:43:22 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534243002/40001
4 years ago (2016-12-01 01:06:27 UTC) #21
nednguyen
On 2016/12/01 01:06:27, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
4 years ago (2016-12-01 01:07:31 UTC) #23
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years ago (2016-12-01 02:07:20 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-01 02:11:43 UTC) #28
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/ba3f0989e24c659d2b204918b40c0ece13cc2335
Cr-Commit-Position: refs/heads/master@{#435527}

Powered by Google App Engine
This is Rietveld 408576698