Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 253423002: Cause the viewport to fit to the PDF document width on load (Closed)

Created:
6 years, 8 months ago by raymes
Modified:
6 years, 7 months ago
CC:
chromium-reviews, arv+watch_chromium.org, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Cause the viewport to fit to the PDF document width on load When the document dimensions are initially set, the zoom should be initially set to fit the document width. If the zoom is greater than 100%, it should be set to 100% as per the current PDF plugin behavior. Comitted in http://src.chromium.org/viewvc/chrome?view=revision&revision=266709 BUG=303491

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/browser/resources/pdf/viewport.js View 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
raymes
6 years, 8 months ago (2014-04-24 07:02:53 UTC) #1
arv (Not doing code reviews)
LGTM
6 years, 8 months ago (2014-04-24 15:54:56 UTC) #2
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 8 months ago (2014-04-27 23:52:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/253423002/1
6 years, 8 months ago (2014-04-27 23:53:07 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-28 00:28:17 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on chromium_presubmit
6 years, 8 months ago (2014-04-28 00:28:18 UTC) #6
raymes
The CQ bit was checked by raymes@chromium.org
6 years, 8 months ago (2014-04-28 00:37:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/253423002/1
6 years, 8 months ago (2014-04-28 00:39:25 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-28 01:24:24 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-28 01:24:24 UTC) #10 
Try jobs failed on following builders:
  tryserver.chromium on chromium_presubmit

Powered by Google App Engine
This is Rietveld 408576698