Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 2534193002: [Contextual Search] Fix flaky tests (Closed)

Created:
4 years ago by Theresa
Modified:
4 years ago
Reviewers:
Donn Denman
CC:
chromium-reviews, twellington+watch_chromium.org, donnd+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Contextual Search] Fix flaky tests Attempt to fix ContextualSearchManagerTest#testImageControl() by running calls to the ContextualSearchImageControl on the UI thread. Also add @RetryOnFailure to #testTapOnRoleIgnored(). BUG=669405, 669565 Committed: https://crrev.com/178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a Cr-Commit-Position: refs/heads/master@{#435040}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -4 lines) Patch
M chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java View 4 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Theresa
ptal
4 years ago (2016-11-29 18:13:59 UTC) #4
Donn Denman
LGTM, thanks!
4 years ago (2016-11-29 18:16:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534193002/1
4 years ago (2016-11-29 18:23:36 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 18:44:03 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 18:46:51 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/178b21a3089c78d3d4dbd3ccdcb7b967959ecf5a
Cr-Commit-Position: refs/heads/master@{#435040}

Powered by Google App Engine
This is Rietveld 408576698