Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Issue 2534183003: Media Controls: don't "cut" controls if fully hidden. (Closed)

Created:
4 years ago by mlamouri (slow - plz ping)
Modified:
4 years ago
Reviewers:
eae
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Media Controls: don't "cut" controls if fully hidden. A media element might be outside of the page and can't be accessed and for some reasons would have the controls enabled. Instead of having a DCHECK, we should early return and use the default value. BUG=664097 R=eae@chromium.org Review-Url: https://codereview.chromium.org/2499013003 Cr-Commit-Position: refs/heads/master@{#433219} (cherry picked from commit 467481c23e2c416c34e5d4a34766d59a5aeefcf2) Committed: https://chromium.googlesource.com/chromium/src/+/142f327a0dd5b924790af733c9e1b2a0f1aee38b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/media/controls/overflow-fully-hidden.html View 1 chunk +41 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
mlamouri (slow - plz ping)
4 years ago (2016-11-29 17:41:54 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
142f327a0dd5b924790af733c9e1b2a0f1aee38b.

Powered by Google App Engine
This is Rietveld 408576698