Issue 2534173003: fix arguments for dartdoc run - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(540)

My Issues | Starred Open | Closed | All

Issue 2534173003: fix arguments for dartdoc run (Closed)

Created:
4 years ago by keertip

Modified:
4 years ago

Reviewers:
Bill Hesse, Brian Wilkerson

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fix arguments for dartdoc run BUG= R=whesse@google.com Committed: https://github.com/dart-lang/sdk/commit/bb74bc6a495d70efa9c7e4e2a7fb30b0c7258906

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix indentation #

Created: 4 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	tools/bots/dart_sdk.py	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 9 (4 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

LGTM, with indentation fix. https://codereview.chromium.org/2534173003/diff/1/tools/bots/dart_sdk.py File tools/bots/dart_sdk.py (right): https://codereview.chromium.org/2534173003/diff/1/tools/bots/dart_sdk.py#newcode60 tools/bots/dart_sdk.py:60: '--rel-canonical-prefix=' + url]) Indentation

4 years ago (2016-11-29 16:23:36 UTC) #6

keertip

Committed patchset #2 (id:20001) manually as bb74bc6a495d70efa9c7e4e2a7fb30b0c7258906 (presubmit successful).

4 years ago (2016-11-29 16:43:22 UTC) #8

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698