xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp - Issue 2534143003: Use unique_ptr in CFXA_FM expressions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

Issue 2534143003: Use unique_ptr in CFXA_FM expressions (Closed)

Patch Set: Nits Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

diff --git a/xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp b/xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

index d54921f99a75df04f399abae2add50f019cf0f5b..7826d9b53c32220a7a8f382df6958890039b0b61 100644

--- a/xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

+++ b/xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp

@@ -19,7 +19,7 @@ TEST(FMCallExpression, more_than_32_arguments) {

for (size_t i = 0; i < 50; i++)

args.push_back(pdfium::MakeUnique<CXFA_FMSimpleExpression>(0, TOKnan));

- CXFA_FMCallExpression callExp(0, exp.release(), std::move(args), true);

+ CXFA_FMCallExpression callExp(0, std::move(exp), std::move(args), true);

CFX_WideTextBuf js;

callExp.ToJavaScript(js);