Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 2534143003: Use unique_ptr in CFXA_FM expressions (Closed)

Created:
4 years ago by npm
Modified:
4 years ago
Reviewers:
Tom Sepez, Wei Li
CC:
pdfium-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Use unique_ptr in CFXA_FM expressions constructors Committed: https://pdfium.googlesource.com/pdfium/+/f11380fc01cc17f05a34859d34c42b495c8ef8be

Patch Set 1 #

Patch Set 2 : Nits #

Total comments: 6

Patch Set 3 : Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -209 lines) Patch
M xfa/fxfa/fm2js/xfa_expression.h View 7 chunks +14 lines, -13 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_expression.cpp View 7 chunks +40 lines, -34 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fmparse.cpp View 1 2 35 chunks +59 lines, -70 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.h View 13 chunks +44 lines, -37 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression.cpp View 15 chunks +71 lines, -54 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_simpleexpression_unittest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
npm
ptal
4 years ago (2016-11-29 16:04:10 UTC) #3
Tom Sepez
nice. LGTM https://codereview.chromium.org/2534143003/diff/20001/xfa/fxfa/fm2js/xfa_fmparse.cpp File xfa/fxfa/fm2js/xfa_fmparse.cpp (right): https://codereview.chromium.org/2534143003/diff/20001/xfa/fxfa/fm2js/xfa_fmparse.cpp#newcode195 xfa/fxfa/fm2js/xfa_fmparse.cpp:195: std::unique_ptr<CXFA_FMExpression> expr; nit: can this move to ...
4 years ago (2016-11-29 17:39:46 UTC) #4
npm
https://codereview.chromium.org/2534143003/diff/20001/xfa/fxfa/fm2js/xfa_fmparse.cpp File xfa/fxfa/fm2js/xfa_fmparse.cpp (right): https://codereview.chromium.org/2534143003/diff/20001/xfa/fxfa/fm2js/xfa_fmparse.cpp#newcode195 xfa/fxfa/fm2js/xfa_fmparse.cpp:195: std::unique_ptr<CXFA_FMExpression> expr; On 2016/11/29 17:39:46, Tom Sepez wrote: > ...
4 years ago (2016-11-29 18:22:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534143003/40001
4 years ago (2016-11-29 18:22:58 UTC) #8
commit-bot: I haz the power
4 years ago (2016-11-29 18:32:40 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/f11380fc01cc17f05a34859d34c42b495c8e...

Powered by Google App Engine
This is Rietveld 408576698