Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1118)

Issue 2534143002: [deoptimizer] Fix deoptimization in {TranslatedState}. (Closed)

Created:
4 years ago by Michael Starzinger
Modified:
4 years ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[deoptimizer] Fix deoptimization in {TranslatedState}. This ensures the deoptimization triggered due to materialization of objects by the {TranslatedState} works in conjunction with OSR. The optimized code used for OSR is not installed on the function, hence needs to be specified explicitly when requesting deoptimization for specific stack frames. R=jarin@chromium.org TEST=mjsunit/regress/regress-crbug-668795 BUG=chromium:668795 Committed: https://crrev.com/204babf5a0389da311b573cbc254c5b4918ed668 Cr-Commit-Position: refs/heads/master@{#41348}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M src/accessors.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M src/deoptimizer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M src/deoptimizer.cc View 3 chunks +5 lines, -7 lines 0 comments Download
M src/runtime/runtime-scopes.cc View 2 chunks +3 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-668795.js View 1 chunk +21 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Michael Starzinger
4 years ago (2016-11-29 10:28:19 UTC) #3
Jarin
lgtm. Thanks!
4 years ago (2016-11-29 10:30:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534143002/1
4 years ago (2016-11-29 11:32:33 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 11:34:13 UTC) #10
commit-bot: I haz the power
4 years ago (2016-11-29 11:34:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/204babf5a0389da311b573cbc254c5b4918ed668
Cr-Commit-Position: refs/heads/master@{#41348}

Powered by Google App Engine
This is Rietveld 408576698