Issue 253413004: Enable mojo js tests which depend on mojom.js files in gen/.

Issue 253413004: Enable mojo js tests which depend on mojom.js files in gen/. (Closed)

Created:
6 years, 8 months ago by yzshen1

Modified:
6 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, viettrungluu+watch_chromium.org, jam, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable mojo js tests which depend on mojom.js files in gen/. The tests are skipped if those mojom.js files don't exist. This is a temporary fix before isolated tests are enabled on Chromium waterfall. TEST=None BUG=351214 R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266135

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -38 lines)			Patch
M	content/browser/webui/web_ui_mojo_browsertest.cc	View	1 2 3	5 chunks	+5 lines, -16 lines	0 comments	Download
M	content/content_tests.gypi	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/apps/js/test/run_apps_js_tests.cc	View		3 chunks	+24 lines, -15 lines	0 comments	Download
M	mojo/bindings/js/run_js_tests.cc	View	1	3 chunks	+13 lines, -7 lines	0 comments	Download
M	mojo/common/test/test_utils.h	View		2 chunks	+7 lines, -0 lines	0 comments	Download
M	mojo/common/test/test_utils_posix.cc	View		2 chunks	+9 lines, -0 lines	0 comments	Download
M	mojo/common/test/test_utils_win.cc	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	mojo/mojo.gyp	View	1 2	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/mojo_apps.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yzshen@chromium.org/253413004/40001

6 years, 8 months ago (2014-04-24 21:16:41 UTC) #4

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

6 years, 8 months ago (2014-04-24 22:04:50 UTC) #5

commit-bot: I haz the power

Try jobs failed on following builders: tryserver.chromium on mac_chromium_rel

6 years, 8 months ago (2014-04-24 22:04:51 UTC) #6

yzshen1

6 years, 8 months ago (2014-04-25 05:17:35 UTC) #7

Message was sent while issue was closed.

Committed patchset #4 manually as r266135 (presubmit successful).

Expand Messages | Collapse Messages