Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Unified Diff: runtime/platform/signal_blocker.h

Issue 253413002: Make opendir test for EINTR again and make NO_RETRY_EXPECTED check in release mode. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/directory_macos.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/platform/signal_blocker.h
diff --git a/runtime/platform/signal_blocker.h b/runtime/platform/signal_blocker.h
index 4ce4b712f6ed9d4f0469098179656186150af460..a9834efcadc4d83ccfeb3bc0debcd6e9c80ed7f4 100644
--- a/runtime/platform/signal_blocker.h
+++ b/runtime/platform/signal_blocker.h
@@ -73,7 +73,9 @@ class ThreadSignalBlocker {
// was expected to not return EINTR, but did it anyway.
#define NO_RETRY_EXPECTED(expression) \
({ intptr_t __result = (expression); \
- ASSERT(__result != -1L || errno != EINTR); \
+ if (__result == -1L && errno == EINTR) { \
+ FATAL("Unexpected EINTR errno"); \
+ } \
__result; })
#define VOID_NO_RETRY_EXPECTED(expression) \
« no previous file with comments | « runtime/bin/directory_macos.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698