Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
strings for particular IDs contain placeholders, and attempts to access the
vector of offsets corresponding to such placeholders. However, in some
situations (http://crbug.com/658902#c18) the localised string may be empty.
This led to an out-of-bounds access and crash on Android.

This CL is the smallest change to handle such situation gracefully -- it checks
the length of the vector with offsets and gives up accessing it if it is empty.
This avoids the crash but results in displaying a UI with empty strings.
Ideally, the UI would also be supressed on these occasions, but that is left
for follow-up CLs. The current situation is already an improvement (password
manager is still not very useful, but at least the browser has a chance to
continue).

The CL also removes the temporary logging put in for the crash investigation.

BUG=658902
Review-Url: https://codereview.chromium.org/2526283002
Cr-Commit-Position: refs/heads/master@{#434482}
(cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)

Committed: https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9360d65fcb00e

[vabr (Chromium), 2016-11-29 07:20:23]

Description was changed from

==========
Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
strings for particular IDs contain placeholders, and attempts to access the
vector of offsets corresponding to such placeholders. However, in some
situations (http://crbug.com/658902#c18) the localised string may be empty.
This led to an out-of-bounds access and crash on Android.

This CL is the smallest change to handle such situation gracefully -- it checks
the length of the vector with offsets and gives up accessing it if it is empty.
This avoids the crash but results in displaying a UI with empty strings.
Ideally, the UI would also be supressed on these occasions, but that is left
for follow-up CLs. The current situation is already an improvement (password
manager is still not very useful, but at least the browser has a chance to
continue).

The CL also removes the temporary logging put in for the crash investigation.

BUG=658902

Review-Url: https://codereview.chromium.org/2526283002
Cr-Commit-Position: refs/heads/master@{#434482}
(cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)
==========

to

==========
Handle empty string in GetSavePasswordDialogTitleTextAndLinkRange gracefully

GetSavePasswordDialogTitleTextAndLinkRange currently assumes that localised
strings for particular IDs contain placeholders, and attempts to access the
vector of offsets corresponding to such placeholders. However, in some
situations (http://crbug.com/658902#c18) the localised string may be empty.
This led to an out-of-bounds access and crash on Android.

This CL is the smallest change to handle such situation gracefully -- it checks
the length of the vector with offsets and gives up accessing it if it is empty.
This avoids the crash but results in displaying a UI with empty strings.
Ideally, the UI would also be supressed on these occasions, but that is left
for follow-up CLs. The current situation is already an improvement (password
manager is still not very useful, but at least the browser has a chance to
continue).

The CL also removes the temporary logging put in for the crash investigation.

BUG=658902

Review-Url: https://codereview.chromium.org/2526283002
Cr-Commit-Position: refs/heads/master@{#434482}
(cherry picked from commit 49ebcf7d64e71c7d3ac71bca66f65d61180bfb8c)

Committed:
https://chromium.googlesource.com/chromium/src/+/910f52d5209148d0ad1afa8cbfb9...
==========

[vabr (Chromium), 2016-11-29 07:20:25]

Committed patchset #1 (id:1) manually as
910f52d5209148d0ad1afa8cbfb9360d65fcb00e.

[vabr (Chromium), 2016-11-29 08:11:11]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2535183002/ by vabr@chromium.org.

The reason for reverting is: Compile failure.
BUG=669394.