Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Issue 2534073002: Add histogram enum for third party VPN (Closed)

Created:
4 years ago by Kevin Cernekee
Modified:
4 years ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add histogram enum for third party VPN This is now plumbed up in shill; update histograms.xml to match. BUG=486182 TEST=trybots Committed: https://crrev.com/2e1f6e2dccc30684e13361f76b451a5b179ba173 Cr-Commit-Position: refs/heads/master@{#434895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Kevin Cernekee
4 years ago (2016-11-29 00:21:38 UTC) #2
Ilya Sherman
lgtm
4 years ago (2016-11-29 03:06:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534073002/1
4 years ago (2016-11-29 03:18:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 04:44:27 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 04:46:35 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e1f6e2dccc30684e13361f76b451a5b179ba173
Cr-Commit-Position: refs/heads/master@{#434895}

Powered by Google App Engine
This is Rietveld 408576698