Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2534063003:
macOS: Do not crash on selecting a color for <input type=color>. (Closed)
DescriptionmacOS: Do not crash on selecting a color for <input type=color>.
Selecting a color in "Developer" palette in "Color Palettes" tab crashes the
browser process because such colors are in NSNamedColorSpace, and
skia::NSDeviceColorToSkColor can't handle it.
We try to convert such colors into genericRGBColorSpace, and ignore them if we
can't convert them.
BUG=661267
Committed: https://crrev.com/2792c4e2d977fce9eabc9aefcf3f206851464402
Cr-Commit-Position: refs/heads/master@{#435114}
Patch Set 1 #
Messages
Total messages: 20 (11 generated)
The CQ bit was checked by tkent@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
tkent@chromium.org changed reviewers: + keishi@chromium.org
keishi@, would you review the code logic please? Reference: http://stackoverflow.com/questions/2687505/cant-convert-nsnamedcolorspace-to-...
LGTM
tkent@chromium.org changed reviewers: + rsesek@chromium.org
rsesek@, would you approve this please?
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by tkent@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1480467503456180, "parent_rev":
"d8be50455f87977a07d4856ae6bb070c6b002e3d", "commit_rev":
"1fdc4cd0fa4d0d0ab5974b409cbe97a59939e4a1"}
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== macOS: Do not crash on selecting a color for <input type=color>. Selecting a color in "Developer" palette in "Color Palettes" tab crashes the browser process because such colors are in NSNamedColorSpace, and skia::NSDeviceColorToSkColor can't handle it. We try to convert such colors into genericRGBColorSpace, and ignore them if we can't convert them. BUG=661267 ========== to ========== macOS: Do not crash on selecting a color for <input type=color>. Selecting a color in "Developer" palette in "Color Palettes" tab crashes the browser process because such colors are in NSNamedColorSpace, and skia::NSDeviceColorToSkColor can't handle it. We try to convert such colors into genericRGBColorSpace, and ignore them if we can't convert them. BUG=661267 Committed: https://crrev.com/2792c4e2d977fce9eabc9aefcf3f206851464402 Cr-Commit-Position: refs/heads/master@{#435114} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/2792c4e2d977fce9eabc9aefcf3f206851464402 Cr-Commit-Position: refs/heads/master@{#435114} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
