Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 2534033002: Blimp: improve FontFetcher mojo ipc unittest (Closed)

Created:
4 years ago by Menglin
Modified:
4 years ago
Reviewers:
Kevin M
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, yzshen+watch_chromium.org, abarth-chromium, nyquist+watch-blimp_chromium.org, Aaron Boodman, marcinjb+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, darin (slow to review), dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Blimp: improve FontFetcher mojo ipc unittest FontFetcherMojoImplUnittest used to just create the impl object directly and fire methods at it. In this change, we use the mojo services framework for service binding and communication. BUG= Committed: https://crrev.com/7658045543f4ba49888b47c12a677e856279f722 Cr-Commit-Position: refs/heads/master@{#434817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M blimp/engine/mojo/font_fetcher_mojo_impl_unittest.cc View 1 chunk +7 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Kevin M
lgtm
4 years ago (2016-11-28 23:51:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2534033002/1
4 years ago (2016-11-28 23:56:19 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-11-29 01:43:37 UTC) #7
commit-bot: I haz the power
4 years ago (2016-11-29 01:48:03 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7658045543f4ba49888b47c12a677e856279f722
Cr-Commit-Position: refs/heads/master@{#434817}

Powered by Google App Engine
This is Rietveld 408576698