Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Issue 253403002: Linux: The App Launcher now appears on the "Internet" menu, not "Other". (Closed)

Created:
6 years, 8 months ago by Matt Giuca
Modified:
6 years, 8 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org
Visibility:
Public.

Description

Linux: The App Launcher now appears on the "Internet" menu, not "Other". If the App Launcher has already been installed, this change will have no effect until chrome is run with the flags: --reset-app-list-install-state --enable-app-list flags. BUG=366445 TEST=Run chrome --reset-app-list-install-state --enable-app-list. Chrome App Launcher shortut should be on "Internet" menu on desktop environments with an applications menu (eg. Gnome Classic or Cinnamon). Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=266274

Patch Set 1 #

Patch Set 2 : Use a global array, instead of a global pointer to a string. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -5 lines) Patch
M chrome/browser/shell_integration_linux.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/shell_integration_linux.cc View 1 7 chunks +23 lines, -4 lines 0 comments Download
M chrome/browser/shell_integration_linux_unittest.cc View 11 chunks +12 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Matt Giuca
6 years, 8 months ago (2014-04-24 03:01:07 UTC) #1
Elliot Glaysher
lgtm
6 years, 8 months ago (2014-04-24 17:24:15 UTC) #2
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-04-25 01:49:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/253403002/20001
6 years, 8 months ago (2014-04-25 02:03:17 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-25 03:01:20 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-25 03:01:20 UTC) #6
Matt Giuca
The CQ bit was checked by mgiuca@chromium.org
6 years, 8 months ago (2014-04-25 03:08:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/253403002/20001
6 years, 8 months ago (2014-04-25 03:11:28 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-25 23:11:47 UTC) #9
Message was sent while issue was closed.
Change committed as 266274

Powered by Google App Engine
This is Rietveld 408576698