Chromium Code Reviews| Index: components/data_use_measurement/core/data_use_ascriber.h |
| diff --git a/components/data_use_measurement/core/data_use_ascriber.h b/components/data_use_measurement/core/data_use_ascriber.h |
| index 58a669cb620c365ff46ca8158a1e2677046d1437..12c76bed337370bc5e13986ae9b6ad5223ace065 100644 |
| --- a/components/data_use_measurement/core/data_use_ascriber.h |
| +++ b/components/data_use_measurement/core/data_use_ascriber.h |
| @@ -39,24 +39,20 @@ class DataUseAscriber { |
| // Returns the DataUseRecorder to which data usage for the given URL should |
| // be ascribed. If no existing DataUseRecorder exists, a new one will be |
| - // created. |
| - virtual DataUseRecorder* GetDataUseRecorder(net::URLRequest* request) = 0; |
| + // created only if |can_create_new| is true. |
| + virtual DataUseRecorder* GetDataUseRecorder(net::URLRequest* request, |
| + bool can_create_new) = 0; |
| + |
| + virtual std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier() |
|
RyanSturm
2016/11/29 20:33:00
add a comment
Not at Google. Contact bengr
2016/11/30 00:21:16
Done.
|
| + const = 0; |
| // Methods called by DataUseNetworkDelegate to propagate data use information: |
| virtual void OnBeforeUrlRequest(net::URLRequest* request); |
| - |
| - virtual void OnBeforeRedirect(net::URLRequest* request, |
| - const GURL& new_location); |
| - |
| virtual void OnNetworkBytesSent(net::URLRequest* request, int64_t bytes_sent); |
| - |
| virtual void OnNetworkBytesReceived(net::URLRequest* request, |
| int64_t bytes_received); |
| - |
| + virtual void OnUrlRequestCompleted(net::URLRequest* request, bool started); |
| virtual void OnUrlRequestDestroyed(net::URLRequest* request); |
| - |
| - virtual std::unique_ptr<URLRequestClassifier> CreateURLRequestClassifier() |
| - const = 0; |
| }; |
| } // namespace data_use_measurement |