components/data_use_measurement/core/data_use_network_delegate_unittest.cc - Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/data_use_measurement/core/data_use_network_delegate_unittest.cc

Issue 2534023002: Create a DataUseRecorder instance for each page load in Chrome. (Closed)

Patch Set: Use emplace to insert; remove copy constructor Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/data_use_measurement/core/data_use_network_delegate.cc ('k') | components/data_use_measurement/core/data_use_recorder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/data_use_measurement/core/data_use_network_delegate_unittest.cc

diff --git a/components/data_use_measurement/core/data_use_network_delegate_unittest.cc b/components/data_use_measurement/core/data_use_network_delegate_unittest.cc

index b671935b00ca21fda6108d4eafe9ff3c466b643a..a7a82d3e6a66684dab1e78471a8c3dd64774a6db 100644

--- a/components/data_use_measurement/core/data_use_network_delegate_unittest.cc

+++ b/components/data_use_measurement/core/data_use_network_delegate_unittest.cc

@@ -38,7 +38,8 @@ class TestDataUseAscriber : public DataUseAscriber {

public:

TestDataUseAscriber() {}

- DataUseRecorder* GetDataUseRecorder(net::URLRequest* request) override {

+ DataUseRecorder* GetDataUseRecorder(net::URLRequest* request,

+ bool can_create_new) override {

return nullptr;

}